Ironic admin_auth_token option should be deprecated

[Eric Brown]

The ironic driver has config options for admin_username, admin_password, admin_auth_token so that the ironic client can authenticate using the keystoneclient.

From nova/virt/ironic/driver.py:

    cfg.StrOpt('admin_auth_token',
               help='Ironic keystone auth token.'),

The keystoneclient has deprecated admin_auth_token since Icehouse (at least) and thus the ironic driver option should similarly be deprecated. The keystone admin token is intended only for bootstrapping keystone, no for other services to utilize.

https://github.com/openstack/python-keystoneclient/blob/stable/icehouse/keystoneclient/middleware/auth_token.py#L244

    cfg.StrOpt('admin_token',
               secret=True,
               help='This option is deprecated and may be removed in a future'
               ' release. Single shared secret with the Keystone configuration'
               ' used for bootstrapping a Keystone installation, or otherwise'
               ' bypassing the normal authentication process. This option'
               ' should not be used, use `admin_user` and `admin_password`'
               ' instead.'),

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179960

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179960
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=317d9d8f13e8a34af189504ae1258d315154cc82
Submitter: Jenkins
Branch: master

commit 317d9d8f13e8a34af189504ae1258d315154cc82
Author: Eric Brown <email address hidden>
Date: Mon May 4 15:30:58 2015 -0700

    Deprecate nova ironic driver's admin_auth_token

    The admin_auth_token config option is deprecated in the keystone
    client and should similarly be deprecated in the ironic driver.

    Change-Id: Ia9981b831ed9159ca3a01a8bb9d5eab7309f9a65
    Closes-Bug: #1451605