Option name missing from ConfigFileValueError

Bug #1451479 reported by Mark Vanderwiel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.config
Fix Released
Undecided
Mark Vanderwiel

Bug Description

It's sometimes hard to find the option with a bad value. In a
couple ConfigFileValueError cases, the option is not included in
the log message.

neutron.conf

ConfigFileValueError: invalid literal for int() with base 10: 'nisim'

Because of this in /etc/neutron/neutron.conf:

    quota_vip = nisim

lbaas_quota_opts = [
 cfg.IntOpt('quota_vip',
 default=10,
 help=_('Number of vips allowed per tenant. '
 'A negative value means unlimited.')),

In other cases, like a boolean option with a blank value, it's hard to track down the issue
with a log message like:

Unexpected boolean value

Would be great to see the option in question included with the log message as in the
default case.

Changed in oslo.config:
assignee: nobody → Mark Vanderwiel (vanderwl)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.config (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179835

Changed in oslo.config:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.config (master)

Reviewed: https://review.openstack.org/179835
Committed: https://git.openstack.org/cgit/openstack/oslo.config/commit/?id=1c62e02af76e4feb941f6e68be1c9b8c822da186
Submitter: Jenkins
Branch: master

commit 1c62e02af76e4feb941f6e68be1c9b8c822da186
Author: Mark Vanderwiel <email address hidden>
Date: Mon May 4 11:12:29 2015 -0500

    Option name missing from ConfigFileValueError

    It's sometimes hard to find the option with a bad value. In a
    couple ConfigFileValueError cases, the option is not included in
    the log message.

    Change-Id: Ib373f5184b7339ebd59a6d7eb53f3b02a5d59f4f
    Closes-Bug: #1451479

Changed in oslo.config:
status: In Progress → Fix Committed
Changed in oslo.config:
milestone: none → 1.12.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.