--router:external=True syntax is invalid

[Roey Dekel]

Kilo syntax is not backward compatibility:

[root@puma14 ~(keystone_admin)]# neutron net-create public --provider:network_type vlan --provider:physical_network physnet --provider:segmentation_id 193 --router:external=True
usage: neutron net-create [-h] [-f {shell,table,value}] [-c COLUMN]
                          [--max-width <integer>] [--prefix PREFIX]
                          [--request-format {json,xml}]
                          [--tenant-id TENANT_ID] [--admin-state-down]
                          [--shared] [--router:external]
                          [--provider:network_type <network_type>]
                          [--provider:physical_network <physical_network_name>]
                          [--provider:segmentation_id <segmentation_id>]
                          [--vlan-transparent {True,False}]
                          NAME
neutron net-create: error: argument --router:external: ignored explicit argument u'True'

Current syntax supports:
[root@puma14 ~(keystone_admin)]# neutron net-create public --provider:network_type vlan --provider:physical_network physnet --provider:segmentation_id 193 --router:external
Created a new network:
+---------------------------+--------------------------------------+
| Field | Value |
+---------------------------+--------------------------------------+
| admin_state_up | True |
| id | df7af5c2-c84b-4991-b370-f8a854c29a80 |
| mtu | 0 |
| name | public |
| provider:network_type | vlan |
| provider:physical_network | physnet |
| provider:segmentation_id | 193 |
| router:external | True |
| shared | False |
| status | ACTIVE |
| subnets | |
| tenant_id | 7e8736e9aba546e98be4a71a92d67a77 |
+---------------------------+--------------------------------------+

[Ihar Hrachyshka (ihar-hrachyshka)]

The fix would be similar to: https://review.openstack.org/#/c/141063/4/neutronclient/neutron/v2_0/subnet.py

[Ihar Hrachyshka (ihar-hrachyshka)]

This may break external automation tools, so should be fixed in time. Raising its priority.

[Ihar Hrachyshka (ihar-hrachyshka)]

The patch that triggered the compat breakage: https://review.openstack.org/#/c/96372/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/182313