Nova gate broke due to failed unit test

[Gary Kotton]

[x]

ft1.13172: nova.tests.unit.virt.vmwareapi.test_read_write_util.ReadWriteUtilTestCase.test_ipv6_host_read_StringException: Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "nova/tests/unit/virt/vmwareapi/test_read_write_util.py", line 49, in test_ipv6_host_read
    verify=False)
  File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 846, in assert_called_once_with
    return self.assert_called_with(*args, **kwargs)
  File "/home/jenkins/workspace/gate-nova-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 835, in assert_called_with
    raise AssertionError(msg)
AssertionError: Expected call: request('get', 'https://[fd8c:215d:178e:c51e:200:c9ff:fed1:584c]:7443/folder/tmp/fake.txt?dcPath=fake_dc&dsName=fake_ds', stream=True, headers={'User-Agent': 'OpenStack-ESX-Adapter'}, allow_redirects=True, verify=False)
Actual call: request('get', 'https://[fd8c:215d:178e:c51e:200:c9ff:fed1:584c]:7443/folder/tmp/fake.txt?dcPath=fake_dc&dsName=fake_ds', stream=True, headers={'User-Agent': 'OpenStack-ESX-Adapter'}, allow_redirects=True, params=None, verify=False)

[Gary Kotton (garyk)]

https://review.openstack.org/#/c/179746/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179757

[OpenStack Infra (hudson-openstack)]

Change abandoned by garyk (<email address hidden>) on branch: master
Review: https://review.openstack.org/179746
Reason: https://review.openstack.org/#/c/179757/
ncftpg

[Matt Riedemann (mriedem)]

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiQWN0dWFsIGNhbGw6IHJlcXVlc3RcIiBBTkQgbWVzc2FnZTpcIk9wZW5TdGFjay1FU1gtQWRhcHRlclwiIEFORCB0YWdzOlwiY29uc29sZVwiIEFORCBidWlsZF9uYW1lOlwiZ2F0ZS1ub3ZhLXB5dGhvbjI3XCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJ1c2VyX2ludGVydmFsIjowfSwic3RhbXAiOjE0MzA3NDg0NDQ5NDAsIm1vZGUiOiIiLCJhbmFseXplX2ZpZWxkIjoiIn0=

82 hits since the requests 2.7.0 release on 5/3.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179757
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=117351d6c46bd6d00cc92fcd234d67a913833cbc
Submitter: Jenkins
Branch: master

commit 117351d6c46bd6d00cc92fcd234d67a913833cbc
Author: Sean Dague <email address hidden>
Date: Mon May 4 07:14:10 2015 -0400

    VMWare: Isolate unit tests from requests

    The test_ipv6_host_read actually tested all the way down to the
    requests url call, which means it's testing a lot of function
    unrelated to the nova code. The interesting part of this test seems to
    be that it builds the ipv6 url correctly.

    Change this into an assert based on that url being correct. We still
    need to mock out the http connection because that's done magically in
    __init__.

    Unblocks nova patches, which are failing on unit test since the latest
    requests release and one of the function signatures changing.

    Change-Id: I8ae4cb00e63cbb0304210dba2cd4993016d852ba
    Closes-bug: #1451389

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/179805

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179805
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c363c2dfd8d66e5f1095e7147a3c6f191f05fc52
Submitter: Jenkins
Branch: stable/kilo

commit c363c2dfd8d66e5f1095e7147a3c6f191f05fc52
Author: Sean Dague <email address hidden>
Date: Mon May 4 07:14:10 2015 -0400

    VMWare: Isolate unit tests from requests

    The test_ipv6_host_read actually tested all the way down to the
    requests url call, which means it's testing a lot of function
    unrelated to the nova code. The interesting part of this test seems to
    be that it builds the ipv6 url correctly.

    Change this into an assert based on that url being correct. We still
    need to mock out the http connection because that's done magically in
    __init__.

    Unblocks nova patches, which are failing on unit test since the latest
    requests release and one of the function signatures changing.

    Conflicts:
            nova/tests/unit/virt/vmwareapi/test_read_write_util.py

    NOTE(mriedem): The conflict is due to commit 80a63292c on master
    not being in stable/kilo.

    Change-Id: I8ae4cb00e63cbb0304210dba2cd4993016d852ba
    Closes-bug: #1451389
    (cherry picked from commit 117351d6c46bd6d00cc92fcd234d67a913833cbc)