OpenStack Shared File Systems Service (Manila)

Fix 'AllocType' read failure in Huawei driver

Bug #1451386 reported by zhongjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
Undecided
zhongjun
OpenStack Shared File Systems Service (Manila) 1.0.0 "liberty"

Bug Description

The 'AllocType' have two values: Thin and Thick.
The following piece of code in the Huawei driver has
incorrect path and as a result the 'AllocType' is always
'None'. The correct values should be "Thin" or "Thick"
only.

'fstype = root.findtext('FILESYSTEM/AllocType')'

In code line 366: '"ALLOCTYPE": 1'
The "Thin" is set as the initial value. If the 'AllocType'
is always 'None', the 'AllocType' can not set as "Thick".
Change 'FILESYSTEM/AllocType' to 'Filesystem/AllocType' in
Huawei driver to avoid 'AllocType' can not be read out.

See original description
zhongjun (jun-zhongjun)
tags: added: kilo
tags: added: kilo-
removed: kilo
tags: added: kilo-backport-potential
removed: kilo-
Changed in manila:
assignee: nobody → zhongjun (jun-zhongjun)
description: updated
zhongjun (jun-zhongjun)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179759

Changed in manila:
status: New → In Progress
zhongjun (jun-zhongjun)
summary: - Fix huawei driver that 'AllocType' can not be set to ‘Thick’
+ Fix 'AllocType' read failure in Huawei driver
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.openstack.org/179759
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=c2a1fe786859314132a4fdfeb8ab3cb6e7ebdb46
Submitter: Jenkins
Branch: master

commit c2a1fe786859314132a4fdfeb8ab3cb6e7ebdb46
Author: zhongjun <email address hidden>
Date: Tue May 5 04:45:08 2015 +0800

    Fix 'AllocType' read failure in Huawei driver

    The 'AllocType' have two values: Thin and Thick.
    The following piece of code in the Huawei driver has
    incorrect path and as a result the 'AllocType' is always
    'None'. The correct values should be "Thin" or "Thick"
    only.

    'fstype = root.findtext('FILESYSTEM/AllocType')'

    In code line 366: '"ALLOCTYPE": 1'
    The "Thin" is set as the initial value. If the 'AllocType'
    is always 'None', the 'AllocType' can not set as "Thick".

    Change 'FILESYSTEM/AllocType' to 'Filesystem/AllocType' in
    Huawei driver to avoid 'AllocType' can not be read out.

    Change-Id: I63b77b8608b313729159d5732a5dae00cbe67034
    Closes-Bug: #1451386

Changed in manila:
status: In Progress → Fix Committed
zhongjun (jun-zhongjun)
description: updated
description: updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/181820

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/kilo)

Reviewed: https://review.openstack.org/181820
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=d1271e6b7857f2d56d891256dac75d49e8730751
Submitter: Jenkins
Branch: stable/kilo

commit d1271e6b7857f2d56d891256dac75d49e8730751
Author: zhongjun <email address hidden>
Date: Tue May 5 04:45:08 2015 +0800

    Fix 'AllocType' read failure in Huawei driver

    The 'AllocType' have two values: Thin and Thick.
    The following piece of code in the Huawei driver has
    incorrect path and as a result the 'AllocType' is always
    'None'. The correct values should be "Thin" or "Thick"
    only.

    'fstype = root.findtext('FILESYSTEM/AllocType')'

    In code line 366: '"ALLOCTYPE": 1'
    The "Thin" is set as the initial value. If the 'AllocType'
    is always 'None', the 'AllocType' can not set as "Thick".

    Change 'FILESYSTEM/AllocType' to 'Filesystem/AllocType' in
    Huawei driver to avoid 'AllocType' can not be read out.

    Change-Id: I63b77b8608b313729159d5732a5dae00cbe67034
    Closes-Bug: #1451386
    (cherry picked from commit c2a1fe786859314132a4fdfeb8ab3cb6e7ebdb46)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in manila:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in manila:
milestone: liberty-1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.