going from swatch to flat color should start with previous swatch color

Bug #1450112 reported by insaner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Wishlist
insaner

Bug Description

Sometimes I want to go from a swatch (non-gradient) color to a flat color, but doing so causes the flat color to start from black instead of from the previously selected swatch color. It would be great to start from the last swatch color, as that is a more intuitive (and useful) starting point for the flat color. Even if the swatch was a gradient, you could always start from the first (or last) stop of the gradient.

Tags: color
su_v (suv-lp)
tags: added: color
Changed in inkscape:
importance: Undecided → Wishlist
status: New → Confirmed
insaner (insaner)
Changed in inkscape:
assignee: nobody → insaner (insaner)
Revision history for this message
insaner (insaner) wrote :

hi all, please test this patch and let me know what success (or failure) you have with it.

Basic testing: create an object, give it a flat color, select "swatch" or "gradient" or "radial gradient" in the "Fill and Stroke" dock, then click on "flat color" again, and see if it retains the desired color.

Revision history for this message
Jabiertxof (jabiertxof) wrote :

Plesae fix this tree hulks.
patching file src/widgets/paint-selector.cpp
Hunk #1 succeeded at 35 (offset -4 lines).
Hunk #2 succeeded at 659 (offset -4 lines).
Hunk #3 succeeded at 708 (offset -4 lines).

Revision history for this message
Jabiertxof (jabiertxof) wrote :

UX: I coudent reproduce the bug.

Revision history for this message
Bryce Harrington (bryce) wrote :

Posted some review comments for the patch on the inkscape-devel list, mainly cosmetics. LGTM otherwise.

Revision history for this message
insaner (insaner) wrote :

Fix committed revision 14109.
Thanks guys

Changed in inkscape:
status: Confirmed → Fix Committed
su_v (suv-lp)
Changed in inkscape:
milestone: none → 0.92
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.