disk_gb trait field defined as int but displayed as string with None value

[Balazs Gibizer]

Using fresh ceilometer in a fresh devstack I see that /etc/ceilometer/event_definitions.yaml contians the disk_gb field as an integer

    disk_gb:
      type: int
      fields: payload.disk_gb

Then when I check the output of the ceilometer event-list the same field displayed as string with a None value

| d42b61f3-31fd-4771-a610-0ce3378012b6 | compute.instance.exists | 2015-04-29T14:00:03.574346 | +------------------------+----------+------------------------------------------+ |
| | | | | name | type | value | |
| | | | +------------------------+----------+------------------------------------------+ |
| | | | | audit_period_beginning | datetime | 2015-04-29T13:00:00 | |
| | | | | audit_period_ending | datetime | 2015-04-29T14:00:00 | |
| | | | | disk_gb | string | None | |
| | | | | ephemeral_gb | string | None | |
| | | | | host | string | Devstack | |
| | | | | instance_id | string | 9a64b9e2-b6b2-4afe-b89a-10e986b3c537 | |
| | | | | instance_type | string | m1.nano | |
| | | | | instance_type_id | integer | 6 | |
| | | | | launched_at | datetime | 2015-04-29T11:48:19 | |
| | | | | memory_mb | integer | 64 | |
| | | | | request_id | string | req-78f434aa-cea0-4984-9bd5-5a8103b4fee5 | |
| | | | | root_gb | string | None | |
| | | | | service | string | compute | |
| | | | | state | string | active | |
| | | | | tenant_id | string | 7e6bce9927f142b28c61799955722c8c | |
| | | | | user_id | string | f9a4cb0fe04f49af95bb0c710c0773a4 | |
| | | | | vcpus | integer | 1 | |
| | | | +------------------------+----------+------------------------------------------+ |

[gordon chung (chungg)]

@Rohit, you have a solution? if not, i can send my patch.

[gordon chung (chungg)]

basically change all:

   if x: -> if x is not None:

https://github.com/openstack/ceilometer/blob/master/ceilometer/event/storage/impl_sqlalchemy.py#L323-L331

[gordon chung (chungg)]

def test_trait_type_enforced_on_none(self):
        new_events = [event_models.Event(
            "id_testid", "MessageIDTest", self.start,
            [event_models.Trait('text', event_models.Trait.TEXT_TYPE, ''),
             event_models.Trait('int', event_models.Trait.INT_TYPE, 0),
             event_models.Trait('float', event_models.Trait.FLOAT_TYPE, 0.0)],
            {})]
        self.event_conn.record_events(new_events)
        event_filter = storage.EventFilter(message_id="id_testid")
        events = [event for event in self.event_conn.get_events(event_filter)]
        options = [event_models.Trait.TEXT_TYPE, event_models.Trait.INT_TYPE,
                   event_models.Trait.FLOAT_TYPE]
        for trait in events[0].traits:
            options.remove(trait.dtype)

here's a test.

[Rohit Jaiswal (rohit-jaiswal-3)]

@gordc: Thanks, I didnt realize you had a fix, unassigning.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178816

[gordon chung (chungg)]

tagging kilo-backport-potential as it affects a 'relatively' small set of cases.

ie.
- only on sql
- only on 0 or 0.0 values

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178816
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=229f9f98b73b73918cd6f768520fdbce7121444f
Submitter: Jenkins
Branch: master

commit 229f9f98b73b73918cd6f768520fdbce7121444f
Author: gordon chung <email address hidden>
Date: Wed Apr 29 15:25:12 2015 -0400

    empty non-string values are returned as string traits

    when an integer or float trait are 0 or 0.0, sql backend incorrect
    returns them as string traits.

    Change-Id: I70b311e24bfab264bc2623a5089cd7971041896e
    Closes-Bug: #1450042