AgentListener doesn't stop after GC cleanup

Bug #1449645 reported by Victor Ryzhenkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
Critical
Stan Lagun

Bug Description

Any application/class may have "destroy" method that is being called during garbage collection. If such method needs to send execution plan to murano-agent (for example to uninstall something) AgentListener will be started and results queue in RabbitMQ will be consumed. After GC phase there is a deployment phase and it typically requires to also send execution plans. Because GC runs on ObjectCopy and deployment on Objects 2 different instances if AgentListener will be created consuming the same queue and stealing messages from each other.

The same bug in upstream: https://bugs.launchpad.net/murano/+bug/1449500

Tags: murano
Changed in mos:
milestone: none → 6.1
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/murano (openstack-ci/fuel-6.1/2014.2)

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: Stan Lagun <email address hidden>
Review: https://review.fuel-infra.org/6376

Changed in mos:
status: Confirmed → In Progress
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/murano (openstack-ci/fuel-6.1/2014.2)

Reviewed: https://review.fuel-infra.org/6376
Submitter: Ekaterina Chernova <email address hidden>
Branch: openstack-ci/fuel-6.1/2014.2

Commit: f723b0638ae9675726ee2cc2c483404e253dc410
Author: Stan Lagun <email address hidden>
Date: Wed May 6 16:10:40 2015

Execute pre/post deployment hooks on GC

Currently pre/post deployment are invoked only for
deployment (actions). Those hooks are used to stop
AgentListener. But they were not executed for GC
phase that could also start AgentListener. As a result
we could get 2 AgentListeners running and stealing
messages from each other

Change-Id: Ie39adacc608a86327eb29715b50ab8060c7b272f
Closes-Bug: #1449645

Changed in mos:
status: In Progress → Won't Fix
status: Won't Fix → Fix Committed
Changed in mos:
status: Fix Committed → Fix Released
Revision history for this message
Victor Ryzhenkin (vryzhenkin) wrote :

Verified on
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "432"
  build_id: "2015-05-18_03-43-53"
  nailgun_sha: "076566b5df37f681c3fd5b139c966d680d81e0a5"
  python-fuelclient_sha: "38765563e1a7f14f45201fd47cf507393ff5d673"
  astute_sha: "cb655a9a9ad26848bcd9d9ace91857b6f4a0ec15"
  fuel-library_sha: "1621cb350af744f497c35f2b3bb889c2041465d8"
  fuel-ostf_sha: "9ce1800749081780b8b2a4a7eab6586583ffaf33"
  fuelmain_sha: "0e970647a83d9a7d336c4cc253606d4dd0d59a60"

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/murano (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Stan Lagun <email address hidden>
Review: https://review.fuel-infra.org/8205

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on openstack/murano (openstack-ci/fuel-7.0/2015.1.0)

Change abandoned by Kirill Zaitsev <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/8205

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.