RBD: On image creation error, image is not deleted

[Gorka Eguileor]

When an exception rises while adding/creating an image, and the image has been created, this new image is not properly deleted.

The fault lies in the `_delete_image` call of the Store.add method that is providing incorrect arguments.

This also affects Glance (Icehouse), since back then glance_store functionality was included there.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/178272

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/178288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178272
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=751f9ae444d25f9beaffee2796095102f884fe8d
Submitter: Jenkins
Branch: master

commit 751f9ae444d25f9beaffee2796095102f884fe8d
Author: Gorka Eguileor <email address hidden>
Date: Tue Apr 28 18:10:38 2015 +0200

    Fix RBD delete image on creation failure

    When an exception rises on RBD store while adding/creating an image, and
    the image has already been created, this new image is not properly
    deleted as it should be.

    Fault lies in incorrect call to Store._delete_image method, as it is
    called with the wrong arguments.

    Change-Id: Ib74f7eafbb04ab893039b480a7d3eaa15e7d59d1
    Closes-Bug: #1449639

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/178288
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=f66170d59121e12973ca3b064c9bff34c697a576
Submitter: Jenkins
Branch: stable/icehouse

commit f66170d59121e12973ca3b064c9bff34c697a576
Author: Gorka Eguileor <email address hidden>
Date: Tue Apr 28 18:55:28 2015 +0200

    Fix Icehouse RBD delete image on creation failure

    When an exception rises on RBD store while adding/creating an image, and
    the image has already been created, this new image is not properly
    deleted as it should be.be

    Fault lies in incorrect call to Store._delete_image method, as it is
    called with the wrong arguments.

    Change-Id: I4fab5b507d5b9d165cdc3a5bb24458b56d6fdebd
    Closes-Bug: #1449639

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/199114

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/199114
Committed: https://git.openstack.org/cgit/openstack/glance_store/commit/?id=b4fde60603eab71a5eaf4ce1deef6c37a9bb776a
Submitter: Jenkins
Branch: stable/kilo

commit b4fde60603eab71a5eaf4ce1deef6c37a9bb776a
Author: Gorka Eguileor <email address hidden>
Date: Tue Apr 28 18:10:38 2015 +0200

    Fix RBD delete image on creation failure

    When an exception rises on RBD store while adding/creating an image, and
    the image has already been created, this new image is not properly
    deleted as it should be.

    Fault lies in incorrect call to Store._delete_image method, as it is
    called with the wrong arguments.

    Change-Id: Ib74f7eafbb04ab893039b480a7d3eaa15e7d59d1
    Closes-Bug: #1449639
    (cherry picked from commit 751f9ae444d25f9beaffee2796095102f884fe8d)