Check that user has provided wf_input in wf that needs it is absent in cron-triggers

Bug #1449519 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Nikolay Makhotkin

Bug Description

Steps to reproduce:
1. Create workflow definition:
version: '2.0'

wf:
  type: direct
  input:
   - var
  tasks:
    hello:
      action: std.echo output="<% $.var %>
      wait-before: 1
      publish:
        result: <% $.hello %>
2. execution "mistral workflow-create <def.yaml>"
3. execute "mistral execution-create wf"
4. Be sure that following error appears:
Invalid input [name=wf, class=WorkflowSpec, missing=[u'var']]
5. execute "mistral cron-trigger-create trigger wf --pattern '* * * * *' "

Observed result:
Cron-trigger was successfully created

Expected result:
The same error like in case of execution creation

Changed in mistral:
importance: Undecided → Medium
status: New → Triaged
milestone: none → liberty-1
Changed in mistral:
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185334

Changed in mistral:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/185334
Committed: https://git.openstack.org/cgit/stackforge/mistral/commit/?id=2761222195ed45d564f05fb432bf844d43750274
Submitter: Jenkins
Branch: master

commit 2761222195ed45d564f05fb432bf844d43750274
Author: Nikolay Mahotkin <email address hidden>
Date: Mon May 25 12:02:45 2015 +0300

    Adding input validation to cron-trigger creation

    Closes-Bug: #1449519

    Change-Id: Ic4542c24bf6b218bd42f50df027dba5e3ed732ac

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
status: Fix Committed → Fix Released
Changed in mistral:
milestone: liberty-1 → liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.