Remove seafaring checkbox on map save, calculate seafaring tag automatically

[TiborB]

The seafaring map tag in map file should be set automatically, not by user clicking on a checkbox - when editing (saving) the map.

I think map should be scanned for portspaces, and if any found just set the flag on. Of course this check is not 100 % reliable.

[GunChleoc (gunchleoc)]

Thanks for filing the bug.

We should only do this if we can make it 100% reliable - why is this not reliable?

[TiborB (tiborb95)]

Because if player sets only one portspace by mistake, the map will be recognized as seafaring - but in fact no seafaring will be possible. But on the other side, also user can make a mistake and mark a map without ports as seafaring map.

[GunChleoc (gunchleoc)]

So the automated check will have to look for at least 2 port spaces then instead of just one. So, it's doable. :)

[Hans Joachim Desserud (hjd)]

I assume it should also automatically remove the tag if I remove all* port spaces from a seafaring map.

Sounds like a nice simplification.

*or all except one

[GunChleoc (gunchleoc)]

Fixed in build19-rc1.