build-all-docker-images triggers unnecessary image build

Bug #1449287 reported by Qiu Yu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Qiu Yu

Bug Description

tools/build-all-docker-images triggers unnecessary image build, usually in the step of "ADD" in Dockerfile. And that is because tools/build-all-docker-images copied the entire docker image folder to temporary working dir, but without preserving original file timestamp

Qiu Yu (unicell)
Changed in kolla:
assignee: nobody → Qiu Yu (unicell)
Changed in kolla:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/177990
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=6b159e78f52d0b5c9663c91f6f0a71caddeb1fd9
Submitter: Jenkins
Branch: master

commit 6b159e78f52d0b5c9663c91f6f0a71caddeb1fd9
Author: Qiu Yu <email address hidden>
Date: Tue Apr 28 12:33:10 2015 +0800

    Preserve file attributes when copying image dirs for build

    Add "-a" to preserve file attributes so that unnecessary Docker image
    build can be avoided. Otherwise, build-all-docker-images will generate
    additional image layer due to timestamp change.

    Change-Id: I893fa0637937c521198f50b1bba203a27c9f00a3
    Closes-Bug: 1449287

Changed in kolla:
status: In Progress → Fix Committed
Steven Dake (sdake)
Changed in kolla:
importance: Undecided → High
Steven Dake (sdake)
Changed in kolla:
milestone: none → liberty-1
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.