Test for deploying a single node within a cluster should be moved to system tests

Bug #1448977 reported by Roman Prykhodchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Roman Prykhodchenko

Bug Description

test_selected_node_deploy fails in python-fuelclient because Nailgun does not allow to deploy nodes if they are not provisioned. Uploading a fake environment with a provisioned node will require too much effort for the results it will give.

Therefore it's reasonable to move that test to system tests. The test should provision a single node within a clusted and check whether Nailgun managed to execute command and whether the client posted a correct output to stdout.

Changed in fuel:
milestone: none → 6.1
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: New → Confirmed
Revision history for this message
Roman Prykhodchenko (romcheg) wrote :

The problem is that we cannot just fake the status of a node in our test, we have to describe the whole test environment and it’s relationship with a test node in the json which is used to populate the test database

IMO that will be a huge waste of time and the result won’t be robust at all

So my proposal is to move this test to system tests from the client.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/178211

Revision history for this message
Roman Prykhodchenko (romcheg) wrote : Re: master branch in python-fuelclient is broken

The patch above skips the test to unlock the CI until the problem is discussed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/178211
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=82d8f6aa649e7a9a439f1cdd290c87f52f540c38
Submitter: Jenkins
Branch: master

commit 82d8f6aa649e7a9a439f1cdd290c87f52f540c38
Author: Roman Prykhodchenko <email address hidden>
Date: Tue Apr 28 16:11:49 2015 +0200

    Skip test_selected_node_deploy

    After I7405ba54d90f6bc986befb5d035b213e4c0f6a73 was merged
    this test stopped working. The feature itself does not seem
    to be affected.

    This patch skips the test to unblock the CI while the problem
    is been discussed.

    Related-bug: #1448977
    Change-Id: Id69392a5ac57ffb2980308616abfb07ba4d701d8

summary: - master branch in python-fuelclient is broken
+ Test for deploying a single node within a cluster should be moved to
+ system tests
description: updated
Changed in fuel:
assignee: Roman Prykhodchenko (romcheg) → Fuel QA Team (fuel-qa)
milestone: 6.1 → 7.0
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Dennis Dmitriev (ddmitriev)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/198443
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=24fa7e99cedb4593bc44fc2766069c5603bb497f
Submitter: Jenkins
Branch: master

commit 24fa7e99cedb4593bc44fc2766069c5603bb497f
Author: Dennis Dmitriev <email address hidden>
Date: Fri Jul 3 21:24:00 2015 +0300

    Add a new test 'cli_selected_nodes_deploy'

    - Add a test that creates a cluster and deploy nodes using
    only Fuel CLI.

    - for tests cli_cluster_deletion and cli_node_deletion_check
    changed dependence on test group from 'prepare_ha_neutron'
    to 'cli_selected_nodes_deploy'

    - Move 'hiera_deploy' test to a separate class:
    'command_line_minimal', because it is used on different CI
    (see bug https://bugs.launchpad.net/fuel/+bug/1425464)

    Change-Id: Ie3c833ccee8ee1e9cae16e9386ad5369dbbf96e8
    Related-Bug:#1448977

Revision history for this message
Dennis Dmitriev (ddmitriev) wrote :

Test for deploying nodes using CLI has been merged. Please proceed with changes to python-fuelclient.

Changed in fuel:
assignee: Dennis Dmitriev (ddmitriev) → Roman Prykhodchenko (romcheg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204667

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/204667
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=471948c26a8c45c091c5593e54e6727405136eca
Submitter: Jenkins
Branch: master

commit 471948c26a8c45c091c5593e54e6727405136eca
Author: Roman Prykhodchenko <email address hidden>
Date: Wed Jul 22 17:31:32 2015 +0200

    Remove test_selected_node_deploy

    That test was moved to system tests so it can
    be now removed from this test suite.

    Closes-bug: #1448977
    Related Change-Id: Ie3c833ccee8ee1e9cae16e9386ad5369dbbf96e8
    Change-Id: Ia260c586567e19fc01e7de6e765a5217159c4057

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Nastya Urlapova (aurlapova) wrote :
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-qa (stable/6.1)

Related fix proposed to branch: stable/6.1
Review: https://review.openstack.org/347293

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-qa (stable/6.1)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/347293
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.