scaling size limiation is not checked correctly

Bug #1448960 reported by Yanyan Hu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
senlin
Fix Released
High
Yanyan Hu

Bug Description

If user provides parameters when triggering webhook, e.g.

curl -i -X 'POST' $WEBHOOK_URL -H 'Content-type: application/json' --data '{"params": {"count": 2}}'

The *count* value will be directly used by the target action function, .e.g ClusterAction.do_scale_out() and thus skip the size limitation check in related policy, e.g. ScalingPolicy. In this case, the actual cluster size could beyond the scope defined in policy.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/177709
Committed: https://git.openstack.org/cgit/stackforge/senlin/commit/?id=7ffd47576e13c9e9fc5e2c23542cf5dfdc7c4b55
Submitter: Jenkins
Branch: master

commit 7ffd47576e13c9e9fc5e2c23542cf5dfdc7c4b55
Author: yanyanhu <email address hidden>
Date: Mon Apr 27 06:29:34 2015 -0400

    Ensure scaling limitation check will always be done

    Currently, when count parameter is directly provided to action
    when webhook is triggered, the size limitation check in
    ScalingPolicy will be skipped. This is incorrect. This patch
    makes ScalingPolicy check the size limitation based on count
    parameter if it is provided.

    Change-Id: Ia30ca829a1c86204721f9202bf0eb36942b25919
    Closes-Bug: #1448960

Changed in senlin:
status: New → Fix Committed
Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → High
assignee: nobody → Yanyan Hu (yanyanhu)
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.