Juju Charms Collection
swift-proxy package

ring sync needs leader-switch tolerance

Bug #1448884 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
swift-proxy (Juju Charms Collection)
Fix Released
High
Edward Hope-Morley
Juju Charms Collection 16.04

Bug Description

Currently if the cluster leader switches during a ring/builder sync across peers, the sync will fail unless the original leader can be restored and the process restarted. This is not yet supported by the charm and while leader switch is hopefully low probability with Juju leadership support, we should be able to recover from this if it happens.

See original description
Tags: openstack

Related branches

lp:~hopem/charms/trusty/swift-proxy/lp1448884
OpenStack Charmers: Pending requested
Diff: 941 lines (+380/-140)
5 files modified
README.Swift_ring_management (+28/-0)
hooks/swift_hooks.py (+128/-45)
lib/swift_utils.py (+133/-65)
unit_tests/test_swift_hooks.py (+11/-9)
unit_tests/test_swift_utils.py (+80/-21)
Edward Hope-Morley (hopem)
description: updated
Revision history for this message
Edward Hope-Morley (hopem) wrote :

With leadership-election support arriving in the 15.07 charm release the idea of autorecovering in the charm makes less sense. This patch will be more of a refactor of the ring sync code to make it clearer what the sync flow is and with a view to adding in some juju actions to recover the cluster should things go wrong during ring syncing.

James Page (james-page)
Changed in swift-proxy (Juju Charms Collection):
milestone: 15.07 → 15.10
James Page (james-page)
Changed in swift-proxy (Juju Charms Collection):
milestone: 15.10 → 16.01
Edward Hope-Morley (hopem)
description: updated
James Page (james-page)
Changed in swift-proxy (Juju Charms Collection):
milestone: 16.01 → 16.04
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-swift-proxy (master)

Reviewed: https://review.openstack.org/287123
Committed: https://git.openstack.org/cgit/openstack/charm-swift-proxy/commit/?id=ccaeae4706dc15561dd7fa16c4e4b8fbaa66aec1
Submitter: Jenkins
Branch: master

commit ccaeae4706dc15561dd7fa16c4e4b8fbaa66aec1
Author: Edward Hope-Morley <email address hidden>
Date: Wed Mar 2 11:34:58 2016 +0000

    Refactor of ring management code

    Make the ring sync code clearer and improve logic around leader
    switching during or after a sync. Also add more debug logs to
    make it easier to debug when things go wrong.

    Closes-Bug: 1448884
    Change-Id: I10d51c74001710b6b7a2502e14370996b15ffb40

Changed in swift-proxy (Juju Charms Collection):
status: In Progress → Fix Committed
James Page (james-page)
Changed in swift-proxy (Juju Charms Collection):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.