Valgrind: Invalid usage of memcpy in SampleUtil::copyWithGain()

[Uwe Klotz]

Valgrind detects an invalid usage of memcpy in SampleUtil::copyWithGain():

==19942== Source and destination overlap in memcpy(0x37314ab0, 0x37314ab0, 8192)
==19942== at 0x4C2E13D: memcpy@@GLIBC_2.14 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==19942== by 0x75BA75: FilterEffect::processChannel(ChannelHandle const&, FilterGroupState*, float const*, float*, unsigned int, unsigned int, EffectProcessor::EnableState, GroupFeatureState const&) (filtereffect.cpp:167)
==19942== by 0x76302B: PerChannelEffectProcessor<FilterGroupState>::process(ChannelHandle const&, float const*, float*, unsigned int, unsigned int, EffectProcessor::EnableState, GroupFeatureState const&) (effectprocessor.h:81)
==19942== by 0x8B65EF: EngineEffect::process(ChannelHandle const&, float const*, float*, unsigned int, unsigned int, EffectProcessor::EnableState, GroupFeatureState const&) (engineeffect.cpp:104)
==19942== by 0x8BAD94: EngineEffectChain::process(ChannelHandle const&, float*, unsigned int, unsigned int, GroupFeatureState const&) (engineeffectchain.cpp:190)
==19942== by 0x8BD67B: EngineEffectRack::process(ChannelHandle const&, float*, unsigned int, unsigned int, GroupFeatureState const&) (engineeffectrack.cpp:51)
==19942== by 0x8BE2AD: EngineEffectsManager::process(ChannelHandle const&, float*, unsigned int, unsigned int, GroupFeatureState const&) (engineeffectsmanager.cpp:139)
==19942== by 0x8CEA6C: EngineDeck::process(float*, int) (enginedeck.cpp:105)
==19942== by 0x8DE225: EngineMaster::processChannels(int) (enginemaster.cpp:332)
==19942== by 0x8E2ACC: EngineMaster::process(int) (enginemaster.cpp:364)
==19942== by 0xB6DD3E: SoundDevicePortAudio::callbackProcessClkRef(unsigned int, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (sounddeviceportaudio.cpp:834)
==19942== by 0x4E3E903: ??? (in /usr/lib64/libportaudio.so.2.0.0)

Fedora 21 x86_64
Build options:
qdebug=1
debug_assertions_fatal=1
test=1
faad=1
tuned=1
opus=1
shoutcast=1
modplug=1
wv=1
ffmpeg=0

[Daniel Schürmann (daschuer)]

Moving this to 2.1 to verify it again before release.

[Be (be.ing)]

I am removing this from the 2.1 milestone. Reassign the milestone if there is actually something that needs to be done for this.

[RJ Skerry-Ryan (rryan)]

Judging from FilterEffect, the copyWithGain with aliasing arguments was removed so I think this is fixed.

[RJ Skerry-Ryan (rryan)]

(first fixed in the 2.1 branch)

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7988