Fix process attribute check in BackupRunner

Bug #1448279 reported by Petr Malik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Petr Malik

Bug Description

Base 'BackupRunner' checks for the 'process' attribute on __exit__
and terminates the runner process if any.
It however always initializes the process to 'None' in the __init__.
That check is therefore always True.
It should change the condition to check for 'None' value instead.

Tags: backup
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177508

Changed in trove:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/177508
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=d68ecc03cba517b68910d5bda2b2ceb786b2fe35
Submitter: Jenkins
Branch: master

commit d68ecc03cba517b68910d5bda2b2ceb786b2fe35
Author: Petr Malik <email address hidden>
Date: Fri Apr 24 15:36:06 2015 -0400

    Fix process attribute check in BackupRunner

    Base 'BackupRunner' checks for the 'process' attribute on __exit__
    and terminates the runner process if any.
    It however always initializes the process to 'None' in the __init__.
    That check is therefore always True.
    It should change the condition to check for 'None' value instead.

    I also made the 'run' method 'protected' to keep it consistent with the
    'pre' and 'post' methods (and also the restore runner which
    has the process handling method protected as well).

    Change-Id: I6e98a47d33de7da95d884fb67b2cfab918183b3b
    Closes-Bug: 1448279

Changed in trove:
status: In Progress → Fix Committed
Changed in trove:
milestone: none → liberty-1
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-1 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.