[compute] db packages are getting installed on compute worker nodes

[Mark Vanderwiel]

There a many places in the various common recipes with code like this:

db_type = node['openstack']['db']['compute']['service_type']
node['openstack']['db']['python_packages'][db_type].each do |pkg|
  package pkg do
    options platform_options['package_overrides']
    action :upgrade
  end
end

The packages are defined here: https://github.com/stackforge/cookbook-openstack-common/blob/master/attributes/database.rb#L108

Since database access is not needed on the compute worker node, these database access packages should not be installed there. These common recipes are pulled in by many other recipes such that in most cases, these database access packages are installed.

These are all the place where these database package are getting installed, need to look at each one to understand if this recipe is only for the compute worker node:

cookbook-openstack-bare-metal/recipes/ironic-common.rb
cookbook-openstack-block-storage/recipes/api.rb
cookbook-openstack-block-storage/recipes/scheduler.rb
cookbook-openstack-block-storage/recipes/volume.rb
cookbook-openstack-compute/recipes/nova-common.rb
cookbook-openstack-compute/recipes/nova-setup.rb
cookbook-openstack-dashboard/recipes/horizon.rb
cookbook-openstack-identity/recipes/server.rb
cookbook-openstack-image/recipes/registry.rb
cookbook-openstack-network/recipes/default.rb
cookbook-openstack-orchestration/recipes/common.rb
cookbook-openstack-telemetry/recipes/common.rb

From the role os-compute-worker, these recipes don't need database access:
  openstack-compute::compute
  openstack-bare-metal::conductor

And when ceilometer is used:
  openstack-telemetry::agent-compute

[Mark Vanderwiel (vanderwl)]

Added Mars and zhiwei to help look at ironic and telemetry, I'll start with compute

[Mark Vanderwiel (vanderwl)]

Since it appears that the common recipe does many setup items, maybe just placing a role gate on this would do the trick here:

role_match = role_included? 'os-compute-worker'

platform_options['memcache_python_packages'].each do |pkg|
  package pkg do
    options platform_options['package_overrides']
    action :upgrade
    only_if { role_match }
  end
end

[Mark Vanderwiel (vanderwl)]

I see that the role_included? method in stuck in network libraries, we need to move that to Common to allow access from all cookbooks.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/177382

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/177387

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/177399

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/177420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/177382
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-common/commit/?id=348aaf4033f26712ed1d3a08719eb47e8cafb1be
Submitter: Jenkins
Branch: master

commit 348aaf4033f26712ed1d3a08719eb47e8cafb1be
Author: Mark Vanderwiel <email address hidden>
Date: Fri Apr 24 13:52:01 2015 -0500

    Move role and recipe include methods to Common

    These small wrappers are now needed by other cookbooks. They
    provide a easy way to create a clean spec test.
    Will put these into the Common openstack library module namespace
    for easy use across the cookbooks.

    Added common role defintion for compute worker. Eventually all
    the role definitions should be moved here.
    Added new spec for these wrappers.

    Change-Id: If548a9d63a42799e1401b18540878eca5ba2a0e1
    Related-Bug: #1448255

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mark Vanderwiel (<email address hidden>) on branch: master
Review: https://review.openstack.org/177420
Reason: Until we settle down the use of ibm-db-alembic package

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mark Vanderwiel (<email address hidden>) on branch: master
Review: https://review.openstack.org/177387
Reason: Until we settle down the use of ibm-db-alembic package

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mark Vanderwiel (<email address hidden>) on branch: master
Review: https://review.openstack.org/177399
Reason: Until we settle down the use of ibm-db-alembic package

[Mark Vanderwiel (vanderwl)]

See above abandoned patches for examples on how to take this forward, I'm not going to work on this one anymore.

[Dr. Jens Harbott (j-harbott)]

Closed as there has been no activity in years. Please create a new bug if this issue still affects you.