devstack plugin for trove should load validation-rules (configration parameter templates) if present

Bug #1448130 reported by Amrith Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Medium
Amrith Kumar

Bug Description

redstack does, devstack currently doesn't.

Here's the piece of code in redstack that is missing in devstack

    if [ -f "$PATH_TROVE"/trove/templates/$DATASTORE_TYPE/validation-rules.json ]; then
        # add the configuration parameters to the database for the kick-start datastore
        rd_manage db_load_datastore_config_parameters "$DATASTORE_TYPE" "$VERSION" \
            "$PATH_TROVE"/trove/templates/$DATASTORE_TYPE/validation-rules.json
    fi

Amrith Kumar (amrith)
Changed in trove:
assignee: nobody → Amrith (amrith)
milestone: none → liberty-1
importance: Undecided → Medium
Changed in trove:
status: New → Confirmed
Changed in trove:
milestone: liberty-1 → liberty-2
Changed in trove:
status: Confirmed → Triaged
milestone: liberty-2 → liberty-3
Changed in trove:
milestone: liberty-3 → ongoing
Amrith Kumar (amrith)
Changed in trove:
milestone: ongoing → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243779

Changed in trove:
status: Triaged → In Progress
Changed in trove:
milestone: mitaka-1 → mitaka-3
Amrith Kumar (amrith)
Changed in trove:
milestone: mitaka-3 → mitaka-rc1
Amrith Kumar (amrith)
Changed in trove:
milestone: mitaka-rc1 → mitaka-rc2
Amrith Kumar (amrith)
Changed in trove:
milestone: mitaka-rc2 → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/243779
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=fde561a58d55c4d7adadf92cdd665aca7c13b4bd
Submitter: Jenkins
Branch: master

commit fde561a58d55c4d7adadf92cdd665aca7c13b4bd
Author: Amrith Kumar <email address hidden>
Date: Tue Nov 10 14:04:27 2015 -0500

    Correct some issues with devstack plugin for trove

    The redstack script used to properly configure validation-rules if
    they were available but devstack never did that. When the plugin was
    created, it didn't do it either.

    In testing the fix for this, it became apparent that the code for
    configuring guest images was never workable; the TOKEN variable was
    never really initialized.

    Both issues have been addressed.

    Change-Id: I6665720831337fba644a30f3ee0d5ccb77ef1e4a
    Closes-Bug: #1448130
    Closes-Bug: #1514951

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/trove 6.0.0.0b2

This issue was fixed in the openstack/trove 6.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.