wrong cinder.conf.sample generation: missing directives for keystone_authtoken (at least)

[Thomas Goirand]

Hi,

When building the Debian Kilo RC1 package of Cinder, I'm generating the cinder.conf.sample file using (the same way tox would do):

tools/config/generate_sample.sh -b . -p cinder -o etc/cinder

Unfortunately, this resulted in a broken cinder.conf.sample, with at least keystone_authtoken missing directives. It stops at "#hash_algorithms = md5" and all what's after is now missing. auth_host, auth_port, auth_protocol, identity_uri, admin_token, admin_user, admin_password and admin_tenant_name are missing directives from the configuration file. "patrickeast" on IRC gave me a file (which I supposed was generated using devstack) and latest trunk, and it seems there's the exact same issue.

[Jay Bryant (jsbryant)]

Strange. Are there any errors being reported when you try to generate the config file? Can you paste an example of what you are getting here?

[Thomas Goirand (thomas-goirand)]

Hi Jay,

Well, even the cinder.conf.sample generated nightly by J. Griffith is wrong. See: http://54.164.167.86/solidfire-ci-logs/cinder-conf-samples/cinder.conf.sample_04_15_2015.txt

Anyway, here's the output when I launch the command:

# tools/config/generate_sample.sh -b . -p cinder -o etc/cinder
/usr/lib/python2.7/dist-packages/novaclient/utils.py:19: DeprecationWarning: The oslo namespace package is deprecated. Please use oslo_serialization instead.
  from oslo.serialization import jsonutils
/usr/lib/python2.7/dist-packages/novaclient/v1_1/__init__.py:30: UserWarning: Module novaclient.v1_1 is deprecated (taken as a basis for novaclient.v2). The preferable way to get client class or object you can find in novaclient.client module.
  warnings.warn("Module novaclient.v1_1 is deprecated (taken as a basis for "

[Thomas Goirand (thomas-goirand)]

If this wasn't clear: my cut/past is right, and the last warning seems truncated upstream (is this novaclient that does it?). BTW, it'd have been nice (and easy) to fix this "Please use oslo_serialization instead" warning... Can we also see this fix for the Kilo release?

[John Griffith (john-griffith)]

Turns out the problem here is that even though we moved to using oslo.config, the incubator versions were never removed from Cinder. The problem is that along with this, genconfig was never updated to call oslo.config libs directly, so it has been generating the wrong config samples for months now.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176857

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/176857
Reason: sad

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176930

[Matt Riedemann (mriedem)]

nova has the same issue according to zigo.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/176986

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176930
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=51a22591a44932463847ed3247899db32ac49444
Submitter: Jenkins
Branch: master

commit 51a22591a44932463847ed3247899db32ac49444
Author: John Griffith <email address hidden>
Date: Thu Apr 23 12:07:12 2015 -0600

    Add external genconfig calls

    After moving to oslo.config we still were using
    incubator config generator. This was ok, but the
    problem is we haven't been pulling config options
    from the oslo libs.

    This is a hack that just appends external lib calls
    and appends those options to the sample file being built.

    Change-Id: I2634b20ef4abd3bf7990f845d59ad3d208db234f
    Closes-Bug: #1447380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176986
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5987bb2290f629e59b0bcced2f8fe22cdeb9cc6d
Submitter: Jenkins
Branch: stable/kilo

commit 5987bb2290f629e59b0bcced2f8fe22cdeb9cc6d
Author: John Griffith <email address hidden>
Date: Thu Apr 23 12:07:12 2015 -0600

    Add external genconfig calls

    After moving to oslo.config we still were using
    incubator config generator. This was ok, but the
    problem is we haven't been pulling config options
    from the oslo libs.

    This is a hack that just appends external lib calls
    and appends those options to the sample file being built.

    Change-Id: I2634b20ef4abd3bf7990f845d59ad3d208db234f
    (cherry picked from commit 51a22591a44932463847ed3247899db32ac49444)
    Closes-Bug: #1447380

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/176995
Reason: Turns out there's a bug in genconfig where 'oslo.' and 'oslo_' are not equivalent. Besides, seems this change isn't interesting anyway.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/177949

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/177949
Reason: Going to abandon again until the genconfig util is fixed up

[Bertie Fulton (bertiefulton)]

For #11 (the change merged into cinder), I am having issues whereby I am getting two DEFAULT and keystone_authtoken sections. If I remove the change I get (at a cursory glance at least) what I would expect.

Since the change was abandoned for nova, is this still required for cinder?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/179287

[OpenStack Infra (hudson-openstack)]

Change abandoned by John Griffith (<email address hidden>) on branch: master
Review: https://review.openstack.org/177949
Reason: Seems fair, full on oslo-config is def the right answer. Had just proposed this as an interm for K release but looks like that wasn't really a concern.

[John Garbutt (johngarbutt)]

This doesn't seem critical, but does need attention.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/179287
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cabe7c1a1d5b35e58fc4ed34b12fcccd4416835e
Submitter: Jenkins
Branch: master

commit 5987bb2290f629e59b0bcced2f8fe22cdeb9cc6d
Author: John Griffith <email address hidden>
Date: Thu Apr 23 12:07:12 2015 -0600

    Add external genconfig calls

    After moving to oslo.config we still were using
    incubator config generator. This was ok, but the
    problem is we haven't been pulling config options
    from the oslo libs.

    This is a hack that just appends external lib calls
    and appends those options to the sample file being built.

    Change-Id: I2634b20ef4abd3bf7990f845d59ad3d208db234f
    (cherry picked from commit 51a22591a44932463847ed3247899db32ac49444)
    Closes-Bug: #1447380

commit b05274c96bc48e749e6ad21633b39158838c313e
Author: Brant Knudson <email address hidden>
Date: Wed Apr 22 14:57:53 2015 -0500

    service child process normal SIGTERM exit

    service.py had some code where the child process would catch the
    SIGTERM from the parent just so it could exit with 1 status rather
    than with an indication that it exited due to SIGTERM. When
    shutting down the parent doesn't care in what way the child ended,
    only that they're all gone, so this code is unnecessary.

    Also, for some reason this caused the child to never exit while
    there was an open connection from a client. Probably something
    with eventlet and signal handling.

    This is a cherry-pick of oslo-incubator commit
    702bc569987854b602ef189655c201c348de84cb .

    Change-Id: I87f3ca4da64fb8070e4d6c3876a2f1ce1a3ca71d
    Closes-Bug: #1446583
    (cherry picked from commit d73ac96d18c66aa4dd5b7d7f8d7c22e8f8434683)

commit 2727e8865ce7b9ef4eec81f7f07b7a0726eb304b
Author: Lucian Petrut <email address hidden>
Date: Fri Mar 27 14:15:25 2015 +0200

    Windows SMBFS: fix volume extend

    The Windows SMBFS driver inherits the Linux SMBFS driver,
    overriding Windows specific methods.

    This commit Ic89cffc93940b7b119cfcde3362f304c9f2875df added the
    volume name as an extra argument to the _do_extend_volume in order
    to check if differencing images are pointing to backing files other
    than the according volume disks.

    Although this is not required on Windows, this method should accept
    this extra argument in order to have the same signature as the
    method it overrides. At the moment, this raises the following
    exception:

    TypeError: _do_extend_volume() takes exactly 3 arguments (4 given)

    Closes-Bug: #1437290
    (cherry picked from commit dca29e9ab3cdde210d3777e7c6b4a6849447058a)
    Change-Id: I868d7de4a2c68f3fc520ba476a5660a84f440bb1

commit cc9bd73479ab4f0d14ee66eccab6fa285b8836b9
Author: Daisuke Fujita <email address hidden>
Date: Wed Apr 15 14:03:31 2015 +0900

    Fix a wrong argument of create method

    Change the argument 'QoSSpecs.create' to 'qos_specs.create'.

    Closes-Bug: #1443331
    (cherry picked from commit a3c0a4104f95acff00d3a9721caa4da730619fb7)
    Change-Id: Iabebc5f1681be75fb06d83...

[Markus Zoeller (markus_z) (mzoeller)]

Solving an inconsistency: The bug is "in progress" but without an assignee.
I set the status to "confirmed" because of comment #18.

Feel free to assign the bug to yourself. If you do so, please set it to
"in progress".