OOPS when communicating with Launchpad

[Brian Murray]

I found the following OOPS recently - OOPS-27d52732fc38de0d36dd34cf64ba6261

The Traceback ends with the following:

  File "/srv/errors.ubuntu.com/production/errors/errors/api/resources.py", line 225, in _handle_request
    for binary in launchpad.get_binaries_in_source_package(package, release):
  File "/srv/errors.ubuntu.com/production/daisy/daisy/launchpad.py", line 336, in get_binaries_in_source_package
    ma = json_request(ma_url)['self_link']
TypeError: string indices must be integers, not str

The package was 'unity8' and the release was unspecified e.g. None.

The json_request function already has some error handling:

def json_request(url):
    try:
        response, content = _http.request(url)
    except httplib2.ServerNotFoundError:
        return ''

    try:
        return json.loads(content)
    except ValueError:
        return ''

However, we don't actually confirm that json_request(ma_url) is not a string and just try and get ['self_link'].