Networks metadata of existing cluster is not updated during upgrade

[Artem Roma]

In FUEL 6.1 version new logic for vips assignment for networks of the cluster was added. Consequently this led to updating of the data migration process for the releases while upgrading to 6.1 ([1][2]). But no updating procedure is defined for network groups metadata which reflects corresponding metadata from the releases and is used for serialization of cluster network configuration by nailgun ([3][4]). Because of that the serialized data doesn't contain any info about vips whatsoever. Such procedure should be added to migrations scripts.

[1]: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/db/migration/alembic_migrations/versions/fuel_6_1.py#l413-414
[2]: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/utils/migration.py#l519-l529
[3]: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/objects/serializers/network_configuration.py#l84
[4]: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/network/manager.py#l317-l339

[Artem Roma (aroma-x)]

Move this to high because the issue affects ostf functioning - https://bugs.launchpad.net/fuel/+bug/1440714

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/176408

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/176408
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=bfd7c2244579e12b92c409c2b5706d7855e39ae8
Submitter: Jenkins
Branch: master

commit bfd7c2244579e12b92c409c2b5706d7855e39ae8
Author: Artem Roma <email address hidden>
Date: Wed Apr 22 20:23:00 2015 +0300

    Add function that updated network_groups metadata

    Because of logic that assigns vips for networks was changed in 6.1
    metadata of network groups should be updated regarding those changes as
    it is used for serialization of network configuration of the cluster.

    Change-Id: Icab88002af0f325c609a5b193416e142427c2ccd
    Closes-Bug: #1447129

[Maksym Strukov (unbelll)]

Steps:
1. Install Fuel 6.0
2. Deploy cluster
3. Upgrade to 6.1
4. Execute fuel network --download --env 1

Expected:
"vips" key exists
///
networks:
- cidr: 10.109.1.0/24
  ...
    - 10.109.1.63
  meta:
    ...
    vips:
    - haproxy
...
///

Verified as fixed in 6.1-408

{"build_id": "2015-05-12_17-03-01", "build_number": "408", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-26_14-25-46", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "58", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"}}, "2014.2.2-6.1": {"VERSION": {"build_id": "2015-05-12_17-03-01", "build_number": "408", "api": "1.0", "fuel-library_sha": "156fb11bbf3e12e7c73a9a3ac785c9d33d4ac343", "nailgun_sha": "042ed77ffdff22a5242ac7f8a6980836d0a5ef1a", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "d9d488c4c675e6dd33eb68b33a79abe591b4c26f", "fuel-ostf_sha": "21afa436e725be1debadf1c207018753b537c7b3", "release": "6.1", "fuelmain_sha": "51b86bb24b27742a22b23e2ae3dfc850c47e5fbf"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "156fb11bbf3e12e7c73a9a3ac785c9d33d4ac343", "nailgun_sha": "042ed77ffdff22a5242ac7f8a6980836d0a5ef1a", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "af6c9c3799b9ec107bcdc6dbf035cafc034526ce", "astute_sha": "d9d488c4c675e6dd33eb68b33a79abe591b4c26f", "fuel-ostf_sha": "21afa436e725be1debadf1c207018753b537c7b3", "release": "6.1", "fuelmain_sha": "51b86bb24b27742a22b23e2ae3dfc850c47e5fbf"}