incorrect SSL header used in example config

Bug #1446836 reported by Eric Peterson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Alex Chan

Bug Description

https://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L35 is wrong - it says 'HTTP_X_FORWARDED_PROTOCOL'.

According to https://docs.djangoproject.com/en/1.7/ref/settings/#secure-proxy-ssl-header (and our observations / experience) it should be 'HTTP_X_FORWARDED_PROTO'.

tags: added: low-hanging-fruit
Alex Chan (alexc2-3)
Changed in horizon:
assignee: nobody → Alex Chan (alexc2-3)
Alex Chan (alexc2-3)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/176061

Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/176061
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=74b384b2fe005021e392085f6017fb8f2c2e6b22
Submitter: Jenkins
Branch: master

commit 74b384b2fe005021e392085f6017fb8f2c2e6b22
Author: Alex Chan <email address hidden>
Date: Tue Apr 21 13:28:26 2015 -0700

    incorrect SSL header used in example config

    Updating the example local_settings.py to have HTTP_X_FORWARDED_PROTO in
    addition to HTTP_X_FORWARDED_PROTOCOL. Only Django 1.4 uses
    HTTP_X_FORWARDED_PROTOCOL and Django 1.5 and up uses HTTP_X_FORWARDED_PROTO
    which is probably the majority of installations.

    Closes-bug: #1446836
    Change-Id: Iebb854cf5e5586c6613b5755d4641ee896056334

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → liberty-1
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-1 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.