VLAN Transparency and MTU advertisement coexistence problem

Bug #1446784 reported by Richard Winters
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton
Kilo
Fix Released
High
Unassigned

Bug Description

Recently added features VLAN Transparency and MTU advertisement can't be stacked together. When attempting to stack them together the following traceback shows in the log.

Test Bed:
 - Kilo based
 - LinuxBridge with VxLAN
 - Mutli node - node1: controller/compute, node2: compute, node3: compute.

I can stack and use each of these features individually just not together.

Controller local.conf details

[[post-config|/etc/neutron/neutron.conf]]
[DEFAULT]
advertise_mtu = True
network_device_mtu = 9000
vlan_transparent = True

[[post-config|/etc/nova/nova.conf]]
[DEFAULT]
network_device_mtu = 9000

[[post-config|/etc/neutron/plugins/ml2/ml2_conf.ini]]
[ml2]
segment_mtu = 1000
path_mtu = 1200

[vxlan]
enable_vxlan=true
local_ip=210.168.1.156

[linux_bridge]
tenant_network_type=vxlan
tunnel_type=vxlan

2015-04-14 16:24:18.642 INFO neutron.plugins.ml2.db [req-868cf7c5-464f-4c88-b87c-538f118896cc admin 41efb914da9e472fb2bf22d52ea7aa6b] Added segment df41aba2-eaf6-451f-85db-5d0f33439709 of type vxlan for network 113dfef5-7074-4049-ac69-5bb5e233564f
2015-04-14 16:24:18.662 ERROR oslo_db.sqlalchemy.exc_filters [req-868cf7c5-464f-4c88-b87c-538f118896cc admin 41efb914da9e472fb2bf22d52ea7aa6b] DB exception wrapped.
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters Traceback (most recent call last):
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 889, in _execute_context
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters context = constructor(dialect, self, conn, *args)
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/default.py", line 573, in _init_compiled
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters param.append(processors[key](compiled_params[key]))
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/processors.py", line 56, in boolean_to_int
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters return int(value)
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters TypeError: int() argument must be a string or a number, not 'object'
2015-04-14 16:24:18.662 TRACE oslo_db.sqlalchemy.exc_filters
2015-04-14 16:24:18.665 ERROR neutron.api.v2.resource [req-868cf7c5-464f-4c88-b87c-538f118896cc admin 41efb914da9e472fb2bf22d52ea7aa6b] create failed
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource Traceback (most recent call last):
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/resource.py", line 83, in resource
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource result = method(request=request, **args)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/api/v2/base.py", line 461, in create
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource obj = obj_creator(request.context, **kwargs)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/plugins/ml2/plugin.py", line 613, in create_network
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource network)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_db/api.py", line 131, in wrapper
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return f(*args, **kwargs)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/plugins/ml2/plugin.py", line 609, in _create_network_with_retries
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return self._create_network_db(context, network)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/plugins/ml2/plugin.py", line 601, in _create_network_db
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource result['id'], network)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/db/db_base_plugin_v2.py", line 973, in update_network
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource subnets = self._get_subnets_by_network(context, id)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/opt/stack/neutron/neutron/db/db_base_plugin_v2.py", line 135, in _get_subnets_by_network
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return subnet_qry.filter_by(network_id=network_id).all()
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/query.py", line 2320, in all
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return list(self)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/query.py", line 2437, in __iter__
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource self.session._autoflush()
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 1198, in _autoflush
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource self.flush()
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 1919, in flush
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource self._flush(objects)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2037, in _flush
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource transaction.rollback(_capture_exception=True)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource compat.reraise(exc_type, exc_value, exc_tb)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/session.py", line 2001, in _flush
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource flush_context.execute()
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/unitofwork.py", line 372, in execute
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource rec.execute(self)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/unitofwork.py", line 526, in execute
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource uow
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/persistence.py", line 60, in save_obj
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource mapper, table, update)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource execute(statement, params)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 729, in execute
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return meth(self, multiparams, params)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return connection._execute_clauseelement(self, multiparams, params)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource compiled_sql, distilled_params
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 893, in _execute_context
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource None, None)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/oslo_db/sqlalchemy/compat/handle_error.py", line 261, in _handle_dbapi_exception
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource e, statement, parameters, cursor, context)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 1155, in _handle_dbapi_exception
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource util.raise_from_cause(newraise, exc_info)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource reraise(type(exception), exception, tb=exc_tb)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/base.py", line 889, in _execute_context
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource context = constructor(dialect, self, conn, *args)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/engine/default.py", line 573, in _init_compiled
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource param.append(processors[key](compiled_params[key]))
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource File "/usr/local/lib/python2.7/dist-packages/sqlalchemy/processors.py", line 56, in boolean_to_int
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource return int(value)
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource DBError: int() argument must be a string or a number, not 'object' (original cause: TypeError: int() argument must be a string or a number, not 'object') u'UPDATE networks SET mtu=%s, vlan_transparent=%s WHERE networks.id = %s' [{'vlan_transparent': <object object at 0x7f5d6deb8400>, 'networks_id': '113dfef5-7074-4049-ac69-5bb5e233564f', 'mtu': 1150}]
2015-04-14 16:24:18.665 TRACE neutron.api.v2.resource

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/176034

Changed in neutron:
status: New → In Progress
Changed in neutron:
milestone: none → kilo-rc2
importance: Undecided → High
Kyle Mestery (mestery)
tags: added: kilo-rc-potential
Revision history for this message
Kyle Mestery (mestery) wrote :

We need this to be released for Kilo, so we need to hold RC2 until the fix merges in master and can be back ported to stable/kilo.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/176034
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f85de393c469d1e649a1c1e5ee1b683246442351
Submitter: Jenkins
Branch: master

commit f85de393c469d1e649a1c1e5ee1b683246442351
Author: Kevin Benton <email address hidden>
Date: Mon Apr 20 22:26:22 2015 -0700

    Only update MTU in update code for MTU

    The ML2 create_network_db was re-passing in the entire network
    with extensions like vlan_transparency present that was causing
    issues in the base update function it was calling.

    This corrects the behavior by having it only update the MTU, which
    is the only thing it was intending to update in the first place.

    Change-Id: I723c5c138e0830de98f6024c7635ec65065e9346
    Closes-Bug: #1446784

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/176619

Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-rc2 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/176619
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cbfb3e487d97998ec49d7faa751bc26202da7d0e
Submitter: Jenkins
Branch: stable/kilo

commit cbfb3e487d97998ec49d7faa751bc26202da7d0e
Author: Kevin Benton <email address hidden>
Date: Mon Apr 20 22:26:22 2015 -0700

    Only update MTU in update code for MTU

    The ML2 create_network_db was re-passing in the entire network
    with extensions like vlan_transparency present that was causing
    issues in the base update function it was calling.

    This corrects the behavior by having it only update the MTU, which
    is the only thing it was intending to update in the first place.

    Change-Id: I723c5c138e0830de98f6024c7635ec65065e9346
    Closes-Bug: #1446784
    (cherry picked from commit f85de393c469d1e649a1c1e5ee1b683246442351)

Thierry Carrez (ttx)
tags: removed: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)
Download full text (11.7 KiB)

Reviewed: https://review.openstack.org/179286
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b8a09568b5bde8b71ad00468c27b757c98d9c0da
Submitter: Jenkins
Branch: master

commit 7260e0e3fc2ea479e80e0962624aca7fd38a1f60
Author: Henry Gessau <email address hidden>
Date: Mon Apr 27 09:59:21 2015 -0400

    Run radvd as root

    During the refactoring of external process management radvd lost
    its root privileges.

    Closes-bug: 1448813

    Change-Id: I84883fe81684afafac9b024282a03f447c8f825a
    (cherry picked from commit a5e54338770fc074e01fa88dbf909ee1af1b66b2)

commit d37e566dcadf8a540eb5f84b668847fa192393a1
Author: Kevin Benton <email address hidden>
Date: Fri Apr 24 00:35:31 2015 -0700

    Don't resync on DHCP agent setup failure

    There are various cases where the DHCP agent will try to
    create a DHCP port for a network and there will be a failure.
    This has primarily been caused by a lack of available IP addresses
    in the allocation pool. Trying to fix all availability corner cases
    on the server side will be very difficult due to race conditions between
    multiple ports being created, the dhcp_agents_per_network parameter, etc.

    This patch just stops the resync attempt on the agent side if a failure
    is caused by an IP address generation problem. Future updates to the subnet
    will cause another attempt so if the tenant does fix the issue they will
    get DHCP service.

    Change-Id: I0896730126d6dca13fe9284b4d812cfb081b6218
    Closes-Bug: #1447883
    (cherry picked from commit db9ac7e0110a0c2ef1b65213317ee8b7f1053ddc)

commit 38211ae67cb76ade85b08c028b6e88bfc867afc9
Author: Ihar Hrachyshka <email address hidden>
Date: Mon Apr 20 17:06:38 2015 +0200

    tests: confirm that _output_hosts_file does not log too often

    I3ad7864eeb2f959549ed356a1e34fa18804395cc didn't include any regression unit
    tests to validate that the method won't ever log too often again,
    reintroducing performance drop in later patches. It didn't play well
    with stable backports of the fix, where context was lost when doing the
    backport, that left the bug unfixed in stable/juno even though the patch
    was merged there [1].

    The patch adds an explicit note in the code that suggests not to add new
    log messages inside the loop to avoid regression, and a unit test was
    added to capture it.

    Once the test is merged in master, it will be proposed for stable/juno
    inclusion, with additional changes that would fix the regression again.

    Related-Bug: #1414218
    Change-Id: I5d43021932d6a994638c348eda277dd8337cf041
    (cherry picked from commit 3b74095a935f6d2027e6bf04cc4aa21f8a1b46f2)

commit 53b3e751f3c7b32bed48c14742d3dd3a1178d00d
Author: Maru Newby <email address hidden>
Date: Thu Apr 9 17:00:57 2015 +0000

    Double functional testing timeout to 180s

    The increase in ovs testing is resulting in job failure due to
    timeouts in test_killed_monitor_respawns. Giving the test more
    time to complete should reduce the failure rate.

    Change-Id: I2ba9b1eb388bfbbebbd6b0f3edb6d5a5ae0bfead
    Closes-Bug: #1442272
    (c...

Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/qos)

Fix proposed to branch: feature/qos
Review: https://review.openstack.org/196097

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/qos)
Download full text (93.9 KiB)

Reviewed: https://review.openstack.org/196097
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=1cfed745d54a6ce9cb3dd4e6f454666d9e6676c2
Submitter: Jenkins
Branch: feature/qos

commit ba7d673d1ddd5bfa5aa1be5b26a59e9a8cd78a9f
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:31:38 2015 -0700

    Remove duplicated call to setup_coreplugin

    The test case for vlan_transparent was calling setup_coreplugin
    before calling the super setUp method which already calls
    setup_coreplugin. This was causing duplicate core plugin fixtures
    which resulted in patching the dhcp periodic check twice.

    Change-Id: Ide4efad42748e799d8e9c815480c8ffa94b27b38
    Partial-Bug: #1468998

commit e64062efa3b793f7c4ce4ab9e62918af4f1bfcc9
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:29:37 2015 -0700

    Remove double mock of dhcp agent periodic check

    The test case for the periodic check was patching a target
    that the core plugin fixture already patched out. This removes
    that and exposes the mock from the fixture so the test case
    can reference it.

    Change-Id: I3adee6a875c497e070db4198567b52aa16b81ce8
    Partial-Bug: #1468998

commit 25ae0429a713143d42f626dd59ed4514ba25820c
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:24:10 2015 -0700

    Remove double fanout mock

    The test_mech_driver was duplicating a fanout mock already setup
    in the setUp routine.

    Change-Id: I5b88dff13113d55c72241d3d5025791a76672ac2
    Partial-Bug: #1468998

commit 993771556332d9b6bbf7eb3f0300cf9d8a2cb464
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 17:55:16 2015 -0700

    Remove double callback manager mocks

    setup_test_registry_instance() in the base test case class gives
    each test its own registry by mocking out the get_callback_manager.
    The L3 agent test cases were duplicating this.

    Partial-Bug: #1468998
    Change-Id: I7356daa846524611e9f92365939e8ad15d1e1cd8

commit 0be1efad93734f11cd63fb3b7bd2983442ce1268
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 16:57:30 2015 -0700

    Remove ensure_dirs double-patch

    test_spawn_radvd called mock.patch on ensure_dirs after the
    setup method already patched it out. This causes issues when
    mock.patch.stopall() is called because the mocks are stored
    as a set and are unwound in a non-deterministic fashion.[1]
    So some of the time they will be undone correctly, but others
    will leave a monkey-patched in mock, causing the ensure_dir
    test to fail.

    1. http://bugs.python.org/issue21239

    Closes-Bug: #1467908
    Change-Id: I321b5fed71dc73bd19b5099311c6f43640726cd4

commit 0a2238e34e72c17ca8a75e36b1f56e41a3ece74e
Author: Sukhdev Kapur <email address hidden>
Date: Thu Jun 25 15:11:28 2015 -0700

    Fix tenant-id in Arista ML2 driver to support HA router

    When HA router is created, the framework creates a network and does
    not specify the tenant-id. This casuse Arista ML2 driver to fail.
    This patch sets the tenant-id when it is not passed explicitly by
    by the network_create() call from the HA r...

tags: added: in-feature-qos
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/196701

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (feature/pecan)

Change abandoned by Kyle Mestery (<email address hidden>) on branch: feature/pecan
Review: https://review.openstack.org/196701
Reason: This is lacking the functional fix [1], so I'll propose a new merge commit which includes that one.

[1] https://review.openstack.org/#/c/196711/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/196920

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (171.5 KiB)

Reviewed: https://review.openstack.org/196920
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7f759c077f8f860c13db92d2ea6b353ef6b70900
Submitter: Jenkins
Branch: feature/pecan

commit 8123144fadd7c5d5e6e56a76ea860512619a2cf6
Author: Moshe Levi <email address hidden>
Date: Sun Jun 28 14:37:14 2015 +0300

    Fix Consolidate sriov agent and driver code

    This patch add mising __init to mech_sriov/mech_driver/
    and update the setup.cfg to the new agent entrypoint

    Trivial Fix

    Change-Id: I53a527081feb78472f496675bbb3c5121d38a14a

commit 8942fccf02e6e179d47582fdb2792a1ca972da21
Author: Assaf Muller <email address hidden>
Date: Mon Jun 29 11:38:51 2015 -0400

    Remove failing SafeFixture tests

    The fixtures 1.3 release attempted to fix the fixtures resource
    leak issue, but failed to do so completely. Our own SafeFixture
    is still needed: The 1.3 release broke our SafeFixture tests,
    but not the usage of SafeFixture itself. This patch removes
    those failing tests for now to unbreak the gate. Jakub reported
    a bug on fixtures 1.3:
    https://bugs.launchpad.net/python-fixtures/+bug/1469759

    We will continue to use SafeFixture until that bug is fixed
    in fixtures, at which point we will be able to require
    fixtures > 1.3.

    Change-Id: I59457c3bb198ff86d5ad55a1e623d008f0034b8f
    Closes-Bug: #1469734

commit 71dffb0a2c1720cd8233a329d32958a0160dd6f5
Author: Kevin Benton <email address hidden>
Date: Mon Jun 29 08:27:41 2015 +0000

    Revert "Removed test_lib module"

    This reverts commit 9a6536de6e1a7fe9b2552adc142e254426b82b6f.

    We pulled all of the plugins out of the tree, many of which still inherit
    from neutron test classes. This change then stated that we no longer
    support testing other plugins. I think this is a bit premature and should
    have been discussed under the subject
    "Neutron plugins can't use neutron plugin unit tests" or something
    similar.

    Change-Id: I68318589f010b731574ea3bfa8df98492bab31fc

commit b20fd81dbd497e058384a0af065dd0f1fdc4c728
Author: Jakub Libosvar <email address hidden>
Date: Fri Jun 5 14:32:51 2015 +0000

    Refactor NetcatTester class

    Following capabilities were added:
       - used transport protocol is passed as a constant instead of bool
       - src port for testing was added
       - connection can be established explicitly
       - change constructor parameters of NetcatTester

    As a part of removing bool for protocol definition
    get_free_namespace_port() was also modified to match the behavior.

    Change-Id: Id2ec322e7f731c05a3754a65411c9a5d8b258126

commit 83e37980dcd0b2bad6d64dd2cb23bcd2891cafca
Author: jingliuqing <email address hidden>
Date: Sat Jun 27 13:41:54 2015 +0800

    Use REST rather than ReST

    Change-Id: I06c9deaab58c5ec13bfeec39fb8fd4b1fe21f42d

commit 1b60df85ba3ad442c2e4e7e52538e1b9a1bf9378
Author: Kevin Benton <email address hidden>
Date: Thu Jun 25 18:34:38 2015 -0700

    Add a double-mock guard to the base test case

    Use mock to patch mock with a check to prevent multiple active
    patches to the...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.