security service fields can not be unset after set operation

Bug #1446696 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
Medium
Julia Varlamova

Bug Description

It is impossible to unset some value from security service if it was set.

See related code: https://github.com/openstack/python-manilaclient/blob/620b54ec/manilaclient/v1/security_services.py#L96

It should be possible to revert back some changes to security services as well as for shares and snapshots.

Tags: python
tags: added: cli
Changed in python-manilaclient:
importance: Undecided → Medium
tags: added: python
removed: cli
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214577

Changed in python-manilaclient:
assignee: nobody → Julia Varlamova (jvarlamova)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/214577
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=4fcccf9e386a5b83790a82d76d74903f9f7db13c
Submitter: Jenkins
Branch: master

commit 4fcccf9e386a5b83790a82d76d74903f9f7db13c
Author: Julia Varlamova <email address hidden>
Date: Wed Aug 19 07:55:55 2015 -0400

    Allow user to unset security service params

    It is impossible to unset some value from security service if it was set.
    Allow user to set security service params (dns_ip, server, domain,
    user, password, name, description) to empty value.

    Closes-bug: #1446696

    Change-Id: Ifea8f49b2007358565686f90a5d56476c4913c86

Changed in python-manilaclient:
status: In Progress → Fix Committed
Changed in python-manilaclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.