vrouter:mpls table overflow and nexthop reference issues

[Anand H. Krishnan]

Boundary checks allow for one extra label than the maximum, causing memory corruption. Also, when a label is changed, reference to old nexthop is not released. Both needs to be addressed.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9335
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9335
Committed: http://github.org/Juniper/contrail-vrouter/commit/f004b0c4d11a0f364b600b492a06accbd54d0fb2
Submitter: Zuul
Branch: R1.10

commit f004b0c4d11a0f364b600b492a06accbd54d0fb2
Author: Anand H. Krishnan <email address hidden>
Date: Tue Apr 21 17:31:30 2015 +0530

Fix improper boundary checks and reference count leaks

Boundary checks allow for one extra label than the maximum, causing
memory corruption. Also, when a label is changed, reference to old
nexthop has to be released. Two harmless boundary checks in nexthop
subysystem is also addressed.

Change-Id: I7c7e8cd39797d8d203cac8087d5e31cf02438452
Closes-BUG: #1446550

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9440
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9441
Submitter: Anand H. Krishnan (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9440
Committed: http://github.org/Juniper/contrail-vrouter/commit/e937aa9b4cace0eac361439403af5fa01355bfe2
Submitter: Zuul
Branch: R2.0

commit e937aa9b4cace0eac361439403af5fa01355bfe2
Author: Anand H. Krishnan <email address hidden>
Date: Mon Apr 20 12:41:11 2015 +0530

Free the defer data in case of errors

To make sure that we flush all the packets that are queued in a flow
entry, we run a defer function. If for any reason this defer was not
scheduled (because the function was called with no hold queue), the
defer data has to be freed.

Closes-BUG: #1436798
(cherry picked from commit 8c30ce9a3e254d45dc4de595cc066f2da21c18d6)

Fix improper boundary checks and reference count leaks

Boundary checks allow for one extra label than the maximum, causing
memory corruption. Also, when a label is changed, reference to old
nexthop has to be released. Two harmless boundary checks in nexthop
subysystem is also addressed.

Closes-BUG: #1446550
Change-Id: I9289265b8a843160fdfe6fffc3e52c131d9b2a4a

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9441
Committed: http://github.org/Juniper/contrail-vrouter/commit/bec0c7944567d270c722a5285e06cde41ddfb824
Submitter: Zuul
Branch: R2.1

commit bec0c7944567d270c722a5285e06cde41ddfb824
Author: Anand H. Krishnan <email address hidden>
Date: Tue Apr 21 17:31:30 2015 +0530

Fix improper boundary checks and reference count leaks

Boundary checks allow for one extra label than the maximum, causing
memory corruption. Also, when a label is changed, reference to old
nexthop has to be released. Two harmless boundary checks in nexthop
subysystem is also addressed.

Change-Id: I7c7e8cd39797d8d203cac8087d5e31cf02438452
Closes-BUG: #1446550

[Anand H. Krishnan (anandhk)]

For 2.20/2.30/mainline, the fixes have gone in as part of

https://bugs.launchpad.net/juniperopenstack/+bug/1446170