make Mixxx mime type aware

Bug #1445885 reported by Daniel Schürmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Committed
High
Unassigned

Bug Description

To improve the detection of various media files. It will be nice to rely on the mime-type detection, rather use the file extension.
We may use libmagic or the Qt 5 mime type support.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote (last edit ):

This is actually a serious bug that may cause various issues:

https://mixxx.discourse.group/t/mixxx-has-stopped-plaing-newly-downloaded-mp3s/23074/21

I have also seen weird decoded audio signals produced by SoundSourceMP3 which might damage output devices. The combination of the dreaded MP3 format in combination with the ancient libmad library for decoding is dangerous.

Changed in mixxx:
importance: Wishlist → High
assignee: nobody → Uwe Klotz (uklotzde)
milestone: none → 2.3.2
Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote (last edit ):
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :

This bug is not fixed completely in 2.3.2. Mixxx still detects the wrong MIME type and tries to open the file with the registered SoundSources.

On Linux some tracks with the wrong file extension can be played if FFmpeg is enabled, because it is capable of playing almost every format and kicks in as a fallback SoundSource. On Windows and macOS .mp3 files that actually contain an AAC stream in DASH container as reported by the user will probably fail to play such a file file.

Even 2.4.x does not fix the wrong file type in Mixxx of previously imported files. I will take a look.

Changed in mixxx:
milestone: 2.3.2 → 2.4.0
Changed in mixxx:
status: Fix Committed → In Progress
Revision history for this message
Uwe Klotz (uklotzde-deactivatedaccount) wrote :
Changed in mixxx:
assignee: Uwe Klotz (uklotzde) → nobody
Changed in mixxx:
status: In Progress → Fix Committed
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7970

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.