Placeholder for 3.0 minor fixes and improvements to control node

[Nischal Sheth]

Placeholder for 3.0 minor fixes and improvements to control node.

- Do not show non-service chain RIs in service chain introspect
- Align columns for BGP and XMPP neighbors in introspect
- Add grep-like functionality for bgp introspect commands
- Display timestamp for deleted instances, peers and tables
- Display timestamp for peering, neighbor and instance configs
- Hide infrequently used and script-only introspect commands
- Parameterize a few mcast tests to run for iBGP and eBGP
- Include raw value in string for unknown codes/subcodes
- Enable logging for bgp_xmpp_inet6vpn_test
- Fix protocol in introspect output for local routes
- Add test to bgp_xmpp_inetvpn_test to send/receive many updates
- Remove redundant class BgpPathAttributeMpRTargetNlri
- Add more info to output of ShowMulticastManagerDetailReq

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9269
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9269
Committed: http://github.org/Juniper/contrail-controller/commit/b8841a1df853be3a9c17dfb0e836cfcc9e219e3b
Submitter: Zuul
Branch: master

commit b8841a1df853be3a9c17dfb0e836cfcc9e219e3b
Author: Nischal Sheth <email address hidden>
Date: Sat Apr 18 21:22:33 2015 -0700

Populate service chain config only if property is set

This cleans up the output of ShowServiceChainReq by not displaying
routing instances that don't have any service chain configuration.

Change-Id: I9063dee37f6cd36ae3d13d86ec5eb8f25ced56af
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9296
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9296
Committed: http://github.org/Juniper/contrail-controller/commit/dc5f6dafd52c12777abdceabda0cae04f5ea4e90
Submitter: Zuul
Branch: master

commit dc5f6dafd52c12777abdceabda0cae04f5ea4e90
Author: Nischal Sheth <email address hidden>
Date: Mon Apr 20 09:23:23 2015 -0700

Align columns for bgp and xmpp neighbors in BgpNeighborListResp

Certain fields were made optional when ShowBgpNeighborSummaryReq command
was added. Some of these fields were not populated for xmpp and others
were not populated for bgp. This resulted in misaligned columns for bgp
and xmpp neighbors in BgpNeighborListResp.

Fix by explicitly setting such fields to empty value as appropriate i.e.
when it could be non-empty for one type of neighbor and empty for other.

Change-Id: I3ab8304856d4e3693c75616274b80c40e0f4bfad
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9469
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9469
Committed: http://github.org/Juniper/contrail-controller/commit/e6982306de195a6cf8e58f0aab245214c295474d
Submitter: Zuul
Branch: master

commit e6982306de195a6cf8e58f0aab245214c295474d
Author: Nischal Sheth <email address hidden>
Date: Fri Apr 17 21:52:35 2015 -0700

Add search string argument to some introspect commands

Add a search string argument to the following comands so that we
can filter the output when dealing with large number of entries:

o ShowRouteSummaryReq - substring match on table name
o ShowRoutingInstanceSummaryReq - substring match on instance name
o ShowMulticastManagerReq - substring match on table name
o ShowBgpInstanceConfigReq - substring match on instance name
o ShowServiceChainReq - substring match on src instance name
o ShowPendingServiceChainReq - substring match on src instance name

Change-Id: Iac2d2b6f35708c4e9b1eae6aa76b0128bf3604c9
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9511
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9511
Committed: http://github.org/Juniper/contrail-controller/commit/999d55d17b5d3b436bc928aa3d40527d8361e1f3
Submitter: Zuul
Branch: master

commit 999d55d17b5d3b436bc928aa3d40527d8361e1f3
Author: Nischal Sheth <email address hidden>
Date: Thu Apr 23 23:28:24 2015 -0700

Display delete and last change timestamps in introspect

Following changes are implemented:

- show delete timestamp for instances, tables and neighbors
- show last change timestamp for instance and neighbor configs

Change-Id: I583d328b3e0171d4575f1ad104f3ac059c70b518
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9527
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9527
Committed: http://github.org/Juniper/contrail-controller/commit/5da3c51ce3dc4a01ebbfe72a8be64f4249d62f26
Submitter: Zuul
Branch: master

commit 5da3c51ce3dc4a01ebbfe72a8be64f4249d62f26
Author: Nischal Sheth <email address hidden>
Date: Sun Apr 26 16:10:40 2015 -0700

Hide infrequently used and script-only introspects

Change-Id: I084a2433284b7dd063fc4aac40f36c01f5a43741
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9620
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9624
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9620
Committed: http://github.org/Juniper/contrail-controller/commit/76dc4e2a669eba1938acd28d4cd970a81d0502e7
Submitter: Zuul
Branch: master

commit 76dc4e2a669eba1938acd28d4cd970a81d0502e7
Author: Nischal Sheth <email address hidden>
Date: Mon Apr 27 21:28:49 2015 -0700

Parameterize a few mcast tests to run for iBGP and eBGP

Change-Id: Ibfc7cb84ea247a9f954765617a5acdea2b8db075
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9800
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9800
Committed: http://github.org/Juniper/contrail-controller/commit/23c4723a07f6fb54aa1802bf97edf888fa562a01
Submitter: Zuul
Branch: master

commit 23c4723a07f6fb54aa1802bf97edf888fa562a01
Author: Nischal Sheth <email address hidden>
Date: Thu Apr 30 14:39:48 2015 -0700

Include raw value in string for unknown codes/subcodes

Change-Id: I9ce306593229de6f6bb85f82a829cfc10c8552c3
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9851
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9851
Committed: http://github.org/Juniper/contrail-controller/commit/e8c025a0afdf77e099f18188fa215a331b936177
Submitter: Zuul
Branch: master

commit e8c025a0afdf77e099f18188fa215a331b936177
Author: Nischal Sheth <email address hidden>
Date: Thu Mar 12 14:32:30 2015 -0700

Enable logging for bgp_xmpp_inet6vpn_test

Change-Id: Id3ef74d47c3df715f297db9303dde0ea03de2a4a
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10012
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10022
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10022
Committed: http://github.org/Juniper/contrail-controller/commit/d6dd398d080184274b6292a66c5a64130afb33e9
Submitter: Zuul
Branch: master

commit d6dd398d080184274b6292a66c5a64130afb33e9
Author: Nischal Sheth <email address hidden>
Date: Tue Apr 7 10:39:19 2015 -0700

Add test to bgp_xmpp_inetvpn_test to send/receive many updates

Change-Id: I22f4a167f2b700aa0f5ebe6dac3601f2be53660e
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10012
Committed: http://github.org/Juniper/contrail-controller/commit/e507c972319379906fea555f9eab80d3eac28850
Submitter: Zuul
Branch: master

commit e507c972319379906fea555f9eab80d3eac28850
Author: Nischal Sheth <email address hidden>
Date: Tue May 5 12:15:38 2015 -0700

Fix protocol in introspect output for local routes

Change-Id: I24673e84ec18e1f97407a93b9ab31e740a464491
Partial-Bug: #1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10880
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10880
Committed: http://github.org/Juniper/contrail-controller/commit/d23ab8727cf3f81118fde7d40efde799319d67e2
Submitter: Zuul
Branch: master

commit d23ab8727cf3f81118fde7d40efde799319d67e2
Author: Nischal Sheth <email address hidden>
Date: Mon May 25 22:22:00 2015 -0700

Add tests to exercise join/leave concurrency code

Change-Id: I08f8c7443a8397ff5df31156922798e0def7581d
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/11706
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/11706
Committed: http://github.org/Juniper/contrail-controller/commit/1325784c318569300e7d623bf15bcfc83eb0ca11
Submitter: Zuul
Branch: master

commit 1325784c318569300e7d623bf15bcfc83eb0ca11
Author: Nischal Sheth <email address hidden>
Date: Tue Jun 16 16:22:08 2015 -0700

Don't skip empty tables if they are deleted

Change-Id: Ifd49bc9bbdad1311edba33a6bcfc960ba2e26782
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12092
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12093
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12093
Committed: http://github.org/Juniper/contrail-controller/commit/59769dfb3011de5d08c2862b8e080ba2085ea0d2
Submitter: Zuul
Branch: master

commit 59769dfb3011de5d08c2862b8e080ba2085ea0d2
Author: Nischal Sheth <email address hidden>
Date: Mon Jun 29 12:09:46 2015 -0700

Improve some control node introspect commands

Following changes are implemented:

- Add numbers of walkers and listeners to ShowRouteTableSummaryResp
- Add search string to ShowBgpNeighborSummaryReq command
- Treat neighbor argument as search string for BgpNeighborReq
- Treat "deleted" as search string for BgpNeighborReq
- Treat "deleted" as search string for ShowRouteTableSummaryReq
- Treat "deleted" as search string for ShowBgpNeighborSummaryReq
- Treat "deleted" as search string for ShowRoutingInstanceSummaryReq

Change-Id: I38301392142fc66a4e4615d82ed4e86743efc757
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12105
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12105
Committed: http://github.org/Juniper/contrail-controller/commit/c6bdf196a11b741ae7bfa640cd6d56f2057909fe
Submitter: Zuul
Branch: master

commit c6bdf196a11b741ae7bfa640cd6d56f2057909fe
Author: Nischal Sheth <email address hidden>
Date: Tue Jun 30 08:51:56 2015 -0700

Cosmetic improvements to CN introspect

Change-Id: I3f36e04a088e47dc279688b8ea73c081cbf81f69
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12162
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12163
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12162
Committed: http://github.org/Juniper/contrail-controller/commit/30d9dc9e0f12f239ff3f915a00484288827f7dbe
Submitter: Zuul
Branch: master

commit 30d9dc9e0f12f239ff3f915a00484288827f7dbe
Author: Nischal Sheth <email address hidden>
Date: Thu Jul 2 13:13:23 2015 -0700

Scrub code in bgp_xmpp_channel.cc

Following changes have been implemented:

- Use appropriate log levels for messages
- Sanitize formatting of log messages
- Make item entry parsing code more readable by using iterators

Change-Id: Ic171c8187b84d2056b21620e252339a4034bcf51
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12252
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12252
Committed: http://github.org/Juniper/contrail-controller/commit/57a03b63113cc0b4e8927a5eaf204613619c77e2
Submitter: Zuul
Branch: master

commit 57a03b63113cc0b4e8927a5eaf204613619c77e2
Author: Nischal Sheth <email address hidden>
Date: Mon Jul 6 17:43:26 2015 -0700

Add logs for bgp/xmpp peer create and delete

Change-Id: Ic7b368038b822bc34a252261240703c3c1097e23
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13109
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13109
Committed: http://github.org/Juniper/contrail-controller/commit/c908eb9c1f5f34f66e327799922027cc88a45efe
Submitter: Zuul
Branch: master

commit c908eb9c1f5f34f66e327799922027cc88a45efe
Author: Nischal Sheth <email address hidden>
Date: Mon Aug 17 09:51:16 2015 -0700

Move code for route introspect into bgp_show_route.cc

While we're at it, make cpplint happy with the new file.

Change-Id: I82cb27a3c4c1f25f00c5e77c0e3d902bba141674
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13421
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/13421
Committed: http://github.org/Juniper/contrail-controller/commit/4a07bfacbbf65e7edd1be13628d0fc0b3f1913cc
Submitter: Zuul
Branch: master

commit 4a07bfacbbf65e7edd1be13628d0fc0b3f1913cc
Author: Nischal Sheth <email address hidden>
Date: Sun Aug 30 18:45:10 2015 -0700

Minor improvements to introspect

Following changes are implemented:

- Hide ClearBgpNeighborReq since it's available only in test mode
- Maintain and display primary path count for bgp/xmpp neighbors

Change-Id: I0c6e0109fcc506ffd755535367e4c6b8a3eb6047
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15212
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15212
Committed: http://github.org/Juniper/contrail-controller/commit/00484e52e63cdf68acedb97ef6095d57cce62dd5
Submitter: Zuul
Branch: master

commit 00484e52e63cdf68acedb97ef6095d57cce62dd5
Author: Nischal Sheth <email address hidden>
Date: Tue Nov 17 14:19:55 2015 -0800

Remove redundant class BgpPathAttributeMpRTargetNlri

Change-Id: I4accd693db2f501a4c00239c6a3b106f1fa88c29
Partial-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16245
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16245
Committed: http://github.org/Juniper/contrail-controller/commit/7cab43d5a451e568372eae2c7b7961fab5583815
Submitter: Zuul
Branch: master

commit 7cab43d5a451e568372eae2c7b7961fab5583815
Author: Nischal Sheth <email address hidden>
Date: Tue Jan 12 11:50:13 2016 -0800

Add more info to output of ShowMulticastManagerDetailReq

Change-Id: I1a27f29905b46d96c1757b96482426b0e8593ed9
Closes-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16759
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16759
Committed: http://github.org/Juniper/contrail-controller/commit/b18a8a93a501955eec268b3c7a90314b3b0d6381
Submitter: Zuul
Branch: master

commit b18a8a93a501955eec268b3c7a90314b3b0d6381
Author: Nischal Sheth <email address hidden>
Date: Mon Feb 1 10:49:43 2016 -0800

Display path flags as a list of strings

Change-Id: I5525d2ee98c7b46c93bfca58c66ae7fa9b48a659
Closes-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/17184
Submitter: Nischal Sheth (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/17184
Committed: http://github.org/Juniper/contrail-controller/commit/a705b5db39b79084dc1349cffdfdc2c05a662317
Submitter: Zuul
Branch: master

commit a705b5db39b79084dc1349cffdfdc2c05a662317
Author: Nischal Sheth <email address hidden>
Date: Thu Feb 11 17:09:20 2016 -0800

Fix name(s) used to identify master routing instance

The term default routing instance is used in the schema to identify the
primary routing instance for a VN.
Use the term master routing instance for the primary routing instance in
ip-fabric VN.

Change-Id: I329f2c0a1cbbed5589687132948cc8304a4180ba
Closes-Bug: 1445856

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25563
Submitter: Ananth Suryanarayana (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/25564
Submitter: Ananth Suryanarayana (<email address hidden>)