task manager log hard codes a reference to MySQL

Bug #1445647 reported by Doug Shelley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Doug Shelley

Bug Description

Noticed this in trove-taskmanager.log:

2015-04-17 18:38:07.121 1883 DEBUG trove.guestagent.api [req-0efbda1c-9ac7-4165-a1a8-c39392c6b63d admin 0ff61bffd9ef491e9ca04643a7b10b66 - - -] Sending the call to stop MySQL on the Guest. stop_db /usr/lib/python2.7/dist-packages/trove/guestagent/api.py:285

notice the text "MySQL" in the message .. in my case I was running postgresql.

This should be changed to "...call to stop the database process on the Guest."

Doug Shelley (0-doug)
Changed in trove:
assignee: nobody → Doug Shelley (0-doug)
Changed in trove:
status: New → Confirmed
tags: added: low-hanging-fruit
Changed in trove:
importance: Undecided → Low
Revision history for this message
Doug Shelley (0-doug) wrote :

Turns out there are several places in guestagent/api.py that refer to mysql...probably makes sense to fix them all in one shot...

Changed in trove:
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/192150

Changed in trove:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/192150
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=c778e4190bf2c27c527e54362e63d106f4f57f36
Submitter: Jenkins
Branch: master

commit c778e4190bf2c27c527e54362e63d106f4f57f36
Author: Doug Shelley <email address hidden>
Date: Tue Jun 16 07:18:35 2015 -0400

    Fixed API string references to MySql

    The guestagent API contained log messages and docstrings that
    referenced MySql. With multi-datastore support, this API is
    now db agnostic and the messages should reflect that.

    Changed occurrences of "MySql" to "database" and fixed grammar
    as appropriate.

    Change-Id: Id44f0d6eda8c0ef1de1d77975713c34088bf302d
    Closes-bug: 1445647

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-1 → 4.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.