Provisioning/deployment can be started for node which doesn't belong to any cluster

Bug #1445531 reported by Artem Roma
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Sebastian Kalinowski

Bug Description

Steps to reproduce:
1. Create cluster (by any available or preferable means);
2. Try to deploy/provision single node which is not added to any cluster (indicated by "discovered" status):

     fuel --env {env_id} node --provision --node {node-id}

Expected:
some meaningful warning message from the client about that the user should add the node to any cluster prior provisioning/deploying it.

Actual:
HTTPError('404 Client Error: Not Found',)

It is completely unclear what is "not found": both node's and env's ids are passed as params.

Changed in fuel:
status: New → Confirmed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 6.1
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Sebastian Kalinowski (prmtl)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/178580

Changed in fuel:
status: Confirmed → In Progress
Changed in fuel:
milestone: 6.1 → 7.0
Revision history for this message
Mike Scherbakov (mihgen) wrote :

Just hit this issue too. I'd consider this as pretty high usability problem. Let's nail this down early in 7.0 cycle.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/178580
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=912f2a72cd279c54c52bb3c86cadc19575f711bc
Submitter: Jenkins
Branch: master

commit 912f2a72cd279c54c52bb3c86cadc19575f711bc
Author: Sebastian Kalinowski <email address hidden>
Date: Wed Apr 29 11:48:00 2015 +0200

    Block deploy/provision action for unassigned nodes

    If user will try to provision or deploy node that is not
    assigned to any environment, error will be printed.
    Also removed required "env" param for deploy/provision
    action since it's not used there.

    Change-Id: I3787c50cb5284b43cbb44261da000baf040cc684
    Closes-Bug: #1445531

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
Revision history for this message
Artem Hrechanychenko (agrechanichenko) wrote :

verified on RC4 (301 ISO)

Changed in fuel:
status: Fix Committed → Fix Released
tags: removed: on-verification
Revision history for this message
Artem Hrechanychenko (agrechanichenko) wrote :

DEPRECATION WARNING: /etc/fuel/client/config.yaml exists and will be used as the source for settings. This behavior is deprecated. Please specify the path to your custom settings file in the FUELCLIENT_CUSTOM_SETTINGS environment variable.
Input nodes are not assigned to any environment!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.