after Difference, Undo shows "Set marker color" (0.91)

[Brynn]

Hi Friends,
This must already be reported, but I can't find it, after a few different searches. I apologize if this is a duplicate.

After I perform Path menu > Difference in 0.91, 32-bit and 64-bit alike, (and not in 0.48.x), Edit menu > Undo and Undo History both show "Set Marker Color" for that step.

After doing the Difference, if I do Path menu > Break Apart, both Edit menu > Undo and Undo History dialog, also both report "Set marker color".

However, if I do something else in between doing Difference and Break Apart, (such as draw a shape or path, or move something), then Undo correctly reports "Break Apart".

Afaict, all the other path operations are reported correctly in Undo.

I could make up a quick test file, if needed. Or I'll be glad to provide any further info that might be needed.

This is on Windows 7, 64-bit, sp1.

Thank you very much,
brynn

[su_v (suv-lp)]

Please attach a test case (Inkscape SVG file, in two versions: saved before and after the path operation), and your current Inkscape preferences file.

[Brynn (brynn4inks-deactivatedaccount)]

Hhmmm....well I saved a file yesterday, in case you would want one. And the problem was happening in that file, every single time I tried it (5 or 6 times). (And was happening in another file too -- at least 10 times in that file. But I made this separate file in case you would ask for it.) But today, it's not doing it. (Not happening in the other file either, today.)

I've seen this happening ("Set marker color", inappropriately in the Undo History) off and on ever since I installed 0.91, but I never had time to figure out what action was being recorded as "set marker color", until yesterday. (I rarely use markers.) So there must be some particular situation that makes it happen. I guess I can only wait for it to happen again, and try to learn what it is.

Do you have any advice? Because even if it starts to happen again, if I can't figure out what's making it happen, you won't be able to reproduce it. And as you know, I'm not very talented with the technical side of Inkscape.

I suppose there's no way to look up the Undo History from yesterday? Well, I could always make screenshots of the Undo History dialog, when it happens again. I know that's not terribly helpful, but at least would prove that it's happening.

What should I do?

Thanks :-)

[Brynn (brynn4inks-deactivatedaccount)]

OH!! It's back! I think the Fill and Stroke dialog has to be open.

Ok here we go. In the ZIP file, please find the following:

test-undo-diff1.svg -- the SVG file before performing the Difference, and then Break Apart
test-undo-diff1.png -- a screenshot showing the Undo History before
test-undo-diff2.svg -- the SVG file after performing the Difference, and then Break Apart
test-undo-diff2.png -- a screenshot showing the Undo History after
my preferences.xml file

The blue square with red ring on top, on the left, is just to show the before. I made that yesterday thinking you would just need 1 file. So it's really irrelevant now.

In the screenshot showing the after, you can see the Fill and Stroke dialog is....I think it's called iconified. But in any case, it needs to be open (not iconified) for the problem to happen. (I had to iconify to show the Undo History dialog, since in 0.91, apparently we can't adjust the size of docked dialogs anymore.) (Actually I'm not sure if that a bug or intended?)

Thanks again,
brynn

[Brynn (brynn4inks-deactivatedaccount)]

Hhmm.... When you said

"Please attach a test case (Inkscape SVG file, in two versions: saved before and after the path operation), and your current Inkscape preferences file."

I thought by "two versions" you meant 1 before and 1 after (total of 2 SVG files). But maybe I missed that meaning. Did you want me to provide 4 SVG files -- before and after in version 0.91 and also before and after in 0.48.5?

[Brynn (brynn4inks-deactivatedaccount)]

More info :-)

When I said that the problem does not happen when the F/S dialog is iconified (if that's what you call it) I was wrong. The problem happens when it's open at all, whether iconified or not.

Also, I've found that drawing a rectangle, when the F/S dialog is open, is also shown as "Set Marker Color" in Undo and Undo History.

I'm not attaching another file, because it should work in one of those already attached. But if you would like a file, let me know, and I'll make 2 more before and after files, and also make screenshots showing what I see in Undo History.

I guess it seems like there might be even more actions which are shown as "Set Marker Color" in Undo and Undo History. If I notice more, I'll just add in future comments (unless you ask me to make more files).

Also, I'll leave it to you to fix the title and/or tags, if you think they should be different :-)

[Alvin Penner (apenner)]

confirmed on Windows 7, 32 bit, Inkscape 0.91 r13725 (Jan 30 2015)

- open Inkscape with no Fill & Stroke dialog
- open file test-diff-undo1.svg
- perform Path->Difference on left rectangle
- note that Edit->Undo says "Difference", and Undo History says "Difference"

- open Inkscape with Fill & Stroke dialog present and docked
- open file test-diff-undo1.svg
- perform Path->Difference on left rectangle
- note that Edit->Undo says "Set marker color", and Undo History says "Set marker color"

[su_v (suv-lp)]

After removing style properties 'marker-start:none;marker-mid:none;marker-end:none;' from the style attribute of the blueish rectangles, the undo history correctly records 'Difference'.

Earlier reports related to those specific marker properties:
* bug #1198530 undo: color of a path with marker
* bug #1357805 0.91 pre2 redo button doesn't work
* bug #1424717 Error when undoing a "cut path" operation
* bug #1449276 Crash on Undo of Break apart with Fill+Stroke Dialog open
* bug #1498912 Crash undoing path division

--
replaces comment 7 with updated list of related reports

[Brynn (brynn4inks-deactivatedaccount)]

Hi again,
I've found a new situation where Undo (both in Edit menu and Undo History) shows "Set Marker Color" inappropriately.

Path menu > Break Apart

It only happens if the Fill and Stroke dialog is open. But it doesn't have to be open in the particular file where it happens. If I have the F/S dialog open in another open file, it causes this "Set Marker Color" issue, even if F/S dialog is not open in the file where I use Break Apart.

I'll be glad to provide a sample file, if necessary. Just let me know.

This is on Windows 7, 64-bit, sp1, and in Inkscape 0.91, 32-bit (exe installer) and 64-bit (7z version).

[Brynn (brynn4inks-deactivatedaccount)]

I can't reproduce this in 1.0 alpha, so I'm declining to migrate to GL.

However, since I can't point to any specific code or patch which fixed it, I will close this as Invalid.