backuppc: modified conffile with script

[Debian Bug Importer]

Automatically imported from Debian bug report #301076 http://bugs.debian.org/301076

[Debian Bug Importer (debzilla)]

Automatically imported from Debian bug report #301076 http://bugs.debian.org/301076

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Wed, 23 Mar 2005 18:57:06 +0100
From: Peter Palfrader <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: backuppc: modified conffile with script

Package: backuppc
Version: 2.1.0-10
Severity: serious

In postinst, you modify /etc/backuppc/config.pl which is a conffile.

http://release.debian.org/sarge_rc_policy.txt:

3. Configuration files

 Packages must not modify their own or other packages conffiles
 programmatically. (The only correct way to modify a conffile is
 the user running an editor specifically; if anything more automated
 is required or useful, configuration files must _NOT_ be handled as
 conffiles)

One possible solution is to move the `hostname` call into the config
file. Or you could just make it not be a conffile.

--- /scratch/etc/backuppc/config.pl 2005-03-03 23:39:20.000000000 +0100
+++ /etc/backuppc/config.pl 2005-03-23 18:55:02.000000000 +0100
@@ -41,7 +41,9 @@
 #
 # Host name on which the BackupPC server is running.
 #
-$Conf{ServerHost} = 'XXXXXX';
+$ENV{'PATH'} = '/bin:/usr/bin';
+delete @ENV{'IFS', 'CDPATH', 'ENV', 'BASH_ENV'};
+$Conf{ServerHost} = `hostname`;

 #
 # TCP port number on which the BackupPC server listens for and accepts
@@ -1610,7 +1612,7 @@
 #
 # URL of the BackupPC_Admin CGI script. Used for email messages.
 #
-$Conf{CgiURL} = 'http://XXXXXX/backuppc/index.cgi';
+$Conf{CgiURL} = 'http://'.$Conf{ServerHost}.'/backuppc/index.cgi';

 #
 # Language to use. See lib/BackupPC/Lang for the list of supported

And remove the handling from the postinst.

[Peter Palfrader (weasel)]

# Automatically generated email from bts, devscripts version 2.8.11
retitle 301076 backuppc: modifies conffile with script

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Wed, 23 Mar 2005 19:54:27 +0100
From: Peter Palfrader <email address hidden>
To: <email address hidden>
Subject: retitle 301076 to backuppc: modifies conffile with script

# Automatically generated email from bts, devscripts version 2.8.11
retitle 301076 backuppc: modifies conffile with script

[Ludovic Drolez (ldrolez)]

Source: backuppc
Source-Version: 2.1.1-1

We believe that the bug you reported is fixed in the latest version of
backuppc, which is due to be installed in the Debian FTP archive:

backuppc_2.1.1-1.diff.gz
  to pool/main/b/backuppc/backuppc_2.1.1-1.diff.gz
backuppc_2.1.1-1.dsc
  to pool/main/b/backuppc/backuppc_2.1.1-1.dsc
backuppc_2.1.1-1_all.deb
  to pool/main/b/backuppc/backuppc_2.1.1-1_all.deb
backuppc_2.1.1.orig.tar.gz
  to pool/main/b/backuppc/backuppc_2.1.1.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ludovic Drolez <email address hidden> (supplier of updated backuppc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 18 Mar 2005 20:25:47 +0100
Source: backuppc
Binary: backuppc
Architecture: source all
Version: 2.1.1-1
Distribution: unstable
Urgency: low
Maintainer: Ludovic Drolez <email address hidden>
Changed-By: Ludovic Drolez <email address hidden>
Description:
 backuppc - high-performance, enterprise-grade system for backing up PCs
Closes: 299852 301076 301084 301087
Changes:
 backuppc (2.1.1-1) unstable; urgency=low
 .
   * New upstream release
   * Do not modify config.pl in the postinst.
     Thanks to Peter Palfrader for the patch. Closes: #301076.
   * Moved the 'rm -rf /etc/backuppc'. Closes: #301084.
   * Check that backuppc.config is not run 2 times before generating
     a random password. Closes: #301087.
   * Added /bin/sh as shell for the backuppc user. Closes: #299852.
Files:
 e767e145e5918db9d3a162199ce6ec87 599 utils optional backuppc_2.1.1-1.dsc
 fadbce1c3d4679dffc98514e48ed7917 353860 utils optional backuppc_2.1.1.orig.tar.gz
 f1aa7c7c4c4285cca719dda51397ba1a 13711 utils optional backuppc_2.1.1-1.diff.gz
 9048f9c18f01f5529983bef8367afb64 413008 utils optional backuppc_2.1.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFCQeBpsRlQAP1GppgRArfaAJ9w12ogP8/CjB8QAgZa0AyyiYhofQCgjZ8W
sGvmZIbsqfgLfqoBeY3NDbs=
=GP31
-----END PGP SIGNATURE-----

[Debian Bug Importer (debzilla)]

Message-Id: <email address hidden>
Date: Wed, 23 Mar 2005 16:47:08 -0500
From: Ludovic Drolez <email address hidden>
To: <email address hidden>
Subject: Bug#301076: fixed in backuppc 2.1.1-1

Source: backuppc
Source-Version: 2.1.1-1

We believe that the bug you reported is fixed in the latest version of
backuppc, which is due to be installed in the Debian FTP archive:

backuppc_2.1.1-1.diff.gz
  to pool/main/b/backuppc/backuppc_2.1.1-1.diff.gz
backuppc_2.1.1-1.dsc
  to pool/main/b/backuppc/backuppc_2.1.1-1.dsc
backuppc_2.1.1-1_all.deb
  to pool/main/b/backuppc/backuppc_2.1.1-1_all.deb
backuppc_2.1.1.orig.tar.gz
  to pool/main/b/backuppc/backuppc_2.1.1.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ludovic Drolez <email address hidden> (supplier of updated backuppc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 18 Mar 2005 20:25:47 +0100
Source: backuppc
Binary: backuppc
Architecture: source all
Version: 2.1.1-1
Distribution: unstable
Urgency: low
Maintainer: Ludovic Drolez <email address hidden>
Changed-By: Ludovic Drolez <email address hidden>
Description:
 backuppc - high-performance, enterprise-grade system for backing up PCs
Closes: 299852 301076 301084 301087
Changes:
 backuppc (2.1.1-1) unstable; urgency=low
 .
   * New upstream release
   * Do not modify config.pl in the postinst.
     Thanks to Peter Palfrader for the patch. Closes: #301076.
   * Moved the 'rm -rf /etc/backuppc'. Closes: #301084.
   * Check that backuppc.config is not run 2 times before generating
     a random password. Closes: #301087.
   * Added /bin/sh as shell for the backuppc user. Closes: #299852.
Files:
 e767e145e5918db9d3a162199ce6ec87 599 utils optional backuppc_2.1.1-1.dsc
 fadbce1c3d4679dffc98514e48ed7917 353860 utils optional backuppc_2.1.1.orig.tar.gz
 f1aa7c7c4c4285cca719dda51397ba1a 13711 utils optional backuppc_2.1.1-1.diff.gz
 9048f9c18f01f5529983bef8367afb64 413008 utils optional backuppc_2.1.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFCQeBpsRlQAP1GppgRArfaAJ9w12ogP8/CjB8QAgZa0AyyiYhofQCgjZ8W
sGvmZIbsqfgLfqoBeY3NDbs=
=GP31
-----END PGP SIGNATURE-----

[Adam Conrad (adconrad)]

This is fixed in version 2.1.0-10ubuntu1.