"--env" option for "start" action of "node" namespace is not in use

Bug #1445103 reported by Artem Roma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
Medium
Artem Roma
8.0.x
Invalid
Medium
Artem Roma

Bug Description

As you can see [1] 'env' param is not processing by client's code but is still present in help string of the command and is mandatory to supply in order to start its execution. It could lead at least to user's confusion and at its most to unexpected results of some operations (please, see related bug [2]).

[1]: https://github.com/stackforge/python-fuelclient/blob/master/fuelclient/cli/actions/node.py#l225-l241
[2]: https://bugs.launchpad.net/fuel/+bug/1445101

Revision history for this message
Dima Shulyak (dshulyak) wrote :

But it is not mandatory.
You are right - it should be removed, afaik there was limitation that you can not remove some variables in same namespace

Revision history for this message
Artem Roma (aroma-x) wrote :

Dima, it is mandatory, because without its supplying you ended up with warning message from pre-check decorator which will interrupt execution of the command.

Revision history for this message
Dima Shulyak (dshulyak) wrote :

I thought about another command

  fuel node --node 12 --start pre_deployment_start

Artem Roma (aroma-x)
Changed in fuel:
milestone: 6.1 → 7.0
Changed in fuel:
status: New → Confirmed
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Does not break anything. Moving to 8.0. Needs to be checked.
@Artem, please ensure bug is still relevant.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Artem Roma (aroma-x)
status: Confirmed → Won't Fix
Revision history for this message
Artem Roma (aroma-x) wrote :

@Aleskey, seems that this issue already being fixed so move this to 'invalid' status

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
status: Won't Fix → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.