OpenStack Shared File Systems Service (Manila)

Pass additional data through parameters to drivers to avoid direct DB usage

Bug #1444914 reported by Igor Malinovskiy on 2015-04-16

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Shared File Systems Service (Manila)	Fix Released	Undecided	Igor Malinovskiy	OpenStack Shared File Systems Service (Manila) 1.0.0 "liberty"

Bug Description

Update create_snapshot(), delete_snapshot() methods in Share Driver interface. Share manager should provide share through parameters to avoid usage of DB API in drivers:

https://github.com/openstack/manila/blob/6aac2b5693fe319dd31fd166bd78fb759712a5b9/manila/share/drivers/glusterfs_native.py#L295
https://github.com/openstack/manila/blob/6aac2b5693fe319dd31fd166bd78fb759712a5b9/manila/share/drivers/glusterfs_native.py#L626
https://github.com/openstack/manila/blob/6aac2b5693fe319dd31fd166bd78fb759712a5b9/manila/share/drivers/glusterfs_native.py#L674

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-04-16: Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/174406

Changed in manila:
assignee:	nobody → Igor Malinovskiy (imalinovskiy)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-04-16:

Fix proposed to branch: master
Review: https://review.openstack.org/174418

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-04-20: Fix merged to manila (master)

Reviewed: https://review.openstack.org/174406
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=6076717efd9743b0f110cc3005e9bdeaefaa5718
Submitter: Jenkins
Branch: master

commit 6076717efd9743b0f110cc3005e9bdeaefaa5718
Author: Igor Malinovskiy <email address hidden>
Date: Fri Apr 17 11:30:20 2015 +0300

Update doc-strings for snapshot methods in Share Driver

Update doc-strings for methods create_snapshot() and
delete_snapshot() in Share Driver

Change-Id: I05e7d9c6b508863b12560f57138a648adace5e41
Partial-Bug: #1444914

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-04-21:

Reviewed: https://review.openstack.org/174418
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=4eb57f53c1c705fa3abf2ab0c2973fe709dbe6c8
Submitter: Jenkins
Branch: master

commit 4eb57f53c1c705fa3abf2ab0c2973fe709dbe6c8
Author: Igor Malinovskiy <email address hidden>
Date: Mon Apr 20 18:16:07 2015 +0300

Remove direct DB calls from glusterfs_native driver

    - Remove direct DB calls from methods create_snapshot() and
    delete_snapshot().
    - Move code from _update_gluster_vols_dict() method to
    ensure_share() method.

Change-Id: I6c95f6d9361093d832a536971a460c3cdda44dcb
Partial-Bug: #1444914

Valeriy Ponomaryov (vponomaryov) on 2015-05-07

Changed in manila:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-05-15: Fix proposed to manila (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/183435

Thierry Carrez (ttx) on 2015-06-24

Changed in manila:
milestone:	none → liberty-1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2015-10-15

Changed in manila:
milestone:	liberty-1 → 1.0.0

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.