Juniper Openstack

Provisoning : When tcp_keepalive_time is already present in sysctl.conf ,Fab will mess up the sysctl.conf

Bug #1444610 reported by Thilak Raj
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
High
Ranjeet R
Juniper Openstack r2.20-fcs
Trunk
Fix Committed
High
Ranjeet R
Juniper Openstack r3.0-fcs

Bug Description

 When tcp_keepalive_time is already present in sysctl.conf ,Fab will mess up the sysctl.conf

Running fab on machine with an en existing sysctl entry for tcp.keepalive will result with
something like below.

net.ipv4.tcp_keepalive_time = 5= 5

https://github.com/Juniper/contrail-fabric-utils/blob/088e600f966c5c5a83bfc2bed8ed0e12e1950c7a/fabfile/tasks/rabbitmq.py#L33

The patter match needs to be something like below.

sed -i 's/^net.ipv4.tcp_keepalive_time.*/net.ipv4.tcp_keepalive_time = 5/' /etc/sysctl.conf

Nagabhushana R (bhushana)
tags: added: provisioning
Changed in juniperopenstack:
importance: Undecided → Medium
Ranjeet R (rranjeet-n)
Changed in juniperopenstack:
importance: Medium → High
Ashish Ranjan (aranjan-n)
information type: Proprietary → Public
tags: added: blocker
Sunil Bakhru (sbakhru)
tags: added: ha
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : R2.20

Review in progress for https://review.opencontrail.org/10254
Submitter: Ranjeet R (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : master

Review in progress for https://review.opencontrail.org/10255
Submitter: Ranjeet R (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/10254
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/046e55e21d8e0b566c6075ace016a48943f77965
Submitter: Zuul
Branch: R2.20

commit 046e55e21d8e0b566c6075ace016a48943f77965
Author: Ranjeet R <email address hidden>
Date: Tue May 12 14:07:15 2015 -0700

Fixes: Provisoning : When tcp_keepalive_time is already present in sysctl.conf,
Fab will mess up the sysctl.conf

The sed match was not looking for "=" sign in its match and hence appending
"=x" to all the existing values if setup_all is run multiple times.

Adding a more generic regex so that it can subsitute correctly.

Change-Id: I672859893f522da58f3ac8467a1bdba26ed4d2c8
ClosesBug:1444610

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/10255
Committed: http://github.org/Juniper/contrail-fabric-utils/commit/39ee49647c93100f6fcd7db7419d3897a35e1a6e
Submitter: Zuul
Branch: master

commit 39ee49647c93100f6fcd7db7419d3897a35e1a6e
Author: Ranjeet R <email address hidden>
Date: Tue May 12 14:12:47 2015 -0700

Fixes: Provisoning : When tcp_keepalive_time is already present in sysctl.conf,
Fab will mess up the sysctl.conf

The sed match was not looking for "=" sign in its match and hence appending
"=x" to all the existing values if setup_all is run multiple times.

Adding a more generic regex so that it can subsitute correctly.

Change-Id: I09a8ad26348335197010467f781d94fc3656f1e1
ClosesBug:1444610

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.