Create a volume should handle OverQuota exception

Bug #1444559 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
jichenjc

Bug Description

we can get exception.OverQuota from cinder layer
but we didn't handle it in API layer when we create volume
this may lead to a 500 error

Tags: volumes
jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/173985

Changed in nova:
status: New → In Progress
jichenjc (jichenjc)
Changed in nova:
importance: Undecided → Low
Matt Riedemann (mriedem)
tags: added: volumes
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/216846

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/173985
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=08611e2f7f825eaef06d0c7730f9ec3f611491fe
Submitter: Jenkins
Branch: master

commit 08611e2f7f825eaef06d0c7730f9ec3f611491fe
Author: jichenjc <email address hidden>
Date: Fri Apr 10 20:22:28 2015 +0800

    Catch OverQuota in volume create function

    Volume API may raise OverQuota exception to nova API
    layer, so nova volume API should catch it and raise
    HTTPForbidden just like other API.

    according to new rule on the footnote[1] of following doc
    https://github.com/openstack/nova/blob/master/doc/source/api_microversion_dev.rst
    no microversion will be used for this change.

    Closes-Bug: 1444559

    Change-Id: Ia782ab9d9a31d37854606f7be82582de6d7bc374

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/216846
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ed647de46456c7a063b540513722c7d20ed57525
Submitter: Jenkins
Branch: master

commit ed647de46456c7a063b540513722c7d20ed57525
Author: Matt Riedemann <email address hidden>
Date: Tue Aug 25 12:11:42 2015 -0700

    Add a note about the 403 response not requiring a microversion

    Change Ia782ab9d9a31d37854606f7be82582de6d7bc374 returns a 403 rather
    than a 500 for OverQuota and adds that to the list of expected errors in
    the v2.1 case.

    There is no microversion change required since the 403 case is implied
    given keystone authentication can fail with a 403 on any API.

    This change updates the docs to mention the exceptional case for 403.

    Related-Bug: #1444559

    Change-Id: I7ea8c5c50d4eac53837f5f76e09277ac185288a9

Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.