Amnesty Mode doesn't work correctly with Backdating

[Thomas Berezansky]

Currently Amnesty Mode does not work correctly with backdating. Instead of voiding all overdue fees it will only override to the backdate date, which is what backdating would do normally, but with the amnesty note attached.

I believe the change in this branch is all that is needed to ensure that amnesty mode ignores the backdate date when voiding overdues:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/amnesty_overrides_backdate

[Michele Morgan (mmorgan)]

Tested this and it works as described. When a backdate is set in Checkin AND the Amnesty Mode circulation modifier is enabled, all fines on the transaction are voided and rows in money.billing.note are annotated appropriately with "Amnesty Checkin". So Amnesty Mode is appropriately overriding a backdate.

My signoff branch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1444514_amnesty_mode_overrides_backdate_signoff

[Ben Shum (bshum)]

Bleh, so this doesn't apply cleanly anymore because of other changes in master and needs rebasing.

The original code applies cleanly to rel_2_8 and rel_2_7 though...

So, I'm going to push the fix with mmorgan's signoff there for the maintenance releases tomorrow, but will coordinate further with tsbere, etc. to get a rebased version for master shortly thereafter for 2.9-beta+

[Thomas Berezansky (tsbere)]

I pushed a rebased branch that I believe fixes this in master now.....though I will admit to not having tested said change this morning, just made sure it was valid perl.

[Ben Shum (bshum)]

Thanks! I've pushed the new variant to master and we can hopefully see this resolved now.