netmap L3 crash in urlresolvers.py

[Peter Gervai]

 Internal Server Error: /netmap/graph/layer3/1/

...

 File "/usr/lib/python2.7/dist-packages/nav/web/netmap/graph.py", line 91, in _json_layer3
    node_a, node_b, nx_metadata in graph.edges_iter(data=True)]

  File "/usr/lib/python2.7/dist-packages/nav/netmap/metadata.py", line 409, in edge_to_json_layer3
    metadata_collection[vlan_id].append(edge.to_json())

  File "/usr/lib/python2.7/dist-packages/nav/netmap/metadata.py", line 313, in to_json
    'target': self.target.to_json() or 'null',

  File "/usr/lib/python2.7/dist-packages/nav/netmap/metadata.py", line 148, in to_json
    self.interface.ifname)})

  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 502, in reverse
    return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))

  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 422, in _reverse_with_prefix
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'ipdevinfo-interface-details-by-name' with arguments '()' and keyword arguments '{'port_name': u'N/A (peer of 666.666.107.214)', 'netbox_sysname': u'//-> Whatever Trunk'}' not found.

[Morten Brekkevold (mbrekkevold)]

If u'//-> Whatever Trunk' is the actual 'netbox_sysname' value as indicated above, I understand why this fails. The URL config will not accept sysnames with slashes in them, since they are path separators in the URI.

Any link produced by this would also not be a valid one, since this looks like a link to an external peer, so NAV cannot show that in ipdevpoll anyway.

Given that my assumptions are correct, I would suggest fixing it by having the code ignore the NoReverseMatch error and not produce a link at all in this case (I think we've fixed this particular code multiple times already, for similar problems :P )

[Morten Brekkevold (mbrekkevold)]

fix here: https://nav.uninett.no/hg/stable/rev/0649e0eee538

[Peter Gervai (grin)]

Yes it does, yes they are, but the fix doesn't seem to.
...
 File "/usr/lib/python2.7/dist-packages/nav/netmap/metadata.py", line 313, in to_json
    """json presentation of Edge"""

  File "/usr/lib/python2.7/dist-packages/nav/netmap/metadata.py", line 148, in to_json
    kwargs=kwargs)

  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 502, in reverse
    return iri_to_uri(resolver._reverse_with_prefix(view, prefix, *args, **kwargs))

  File "/usr/lib/python2.7/dist-packages/django/core/urlresolvers.py", line 422, in _reverse_with_prefix
    "arguments '%s' not found." % (lookup_view_s, args, kwargs))

NoReverseMatch: Reverse for 'ipdevinfo-interface-details-by-name' with arguments '()' and keyword arguments '{'port_name': u'N/A (peer of 195.111.107.214)', 'netbox_sysname': u'//-> Whatever Trunk'}' not found.

[Peter Gervai (grin)]

Sorry it seems lame person forgot to restart the indian. I mean the apache.