workload_collector user are not created during 6.0->6.1 upgrade

[Maksym Strukov]

Env:
{"build_id": "2015-04-13_22-54-31", "ostf_sha": "c2a76a60ec4ebbd78e508216c2e12787bf25e423", "build_number": "310", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-26_14-25-46", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "58", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"}}, "2014.2-6.1": {"VERSION": {"build_id": "2015-04-13_22-54-31", "ostf_sha": "c2a76a60ec4ebbd78e508216c2e12787bf25e423", "build_number": "310", "api": "1.0", "nailgun_sha": "d22c074dec091e5ddd8ea3003c37665058303cd5", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "9208ff4a08dcb674ce2df132399a5aa3ddfac21c", "astute_sha": "d96a80b63198a578b2c159edbd76048819039eb0", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "335d3ed09ed79bd37e1f7a90442c4831c8845582", "fuellib_sha": "8b80657e9ceed8d59c2dff1c11e1481c7e69380e"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "d22c074dec091e5ddd8ea3003c37665058303cd5", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "9208ff4a08dcb674ce2df132399a5aa3ddfac21c", "astute_sha": "d96a80b63198a578b2c159edbd76048819039eb0", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "335d3ed09ed79bd37e1f7a90442c4831c8845582", "fuellib_sha": "8b80657e9ceed8d59c2dff1c11e1481c7e69380e"}

Steps:
1. Install 6.0-58, deploy cluster
2. Upgrade to 6.1-310
3. Check oswl_stats: select * from oswl_stats;

Expected: 6.0 cluster appeared in oswl_stats;
Actual: empty

4. Run 'oswl_collectord vm'
Actual: http://paste.openstack.org/show/203948/

During upgrade workload_collector are not created

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/174900

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/174900
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=bc0b3adc2c4a2ce523ce8925d1bf9871ee53bdc8
Submitter: Jenkins
Branch: master

commit bc0b3adc2c4a2ce523ce8925d1bf9871ee53bdc8
Author: Artem Roma <email address hidden>
Date: Fri Apr 17 15:54:51 2015 +0300

    Exploit default OS credentials for clusters w/o workloads_collector user

    Due to service user "workloads_collector" is not created for clusters
    with older version than 6.1 after upgrade of master node, oswl
    collecting procedure fails for those clusters. This fix adds workaround
    to the problem by falling back to default credentials for the cluster to
    be used for OS clients initialization. Please, be advised that such
    approach will not work in case the user changed the credentials for the
    cluster.

    Change-Id: I65e9029fec3055a1e1f1179d77696b0338743663
    Closes-Bug: #1444410
    Closes-Bug: #1444362

[Maksym Strukov (unbelll)]

Re-checked with the same steps (6.0-58 => 6.1-329)

{"build_id": "2015-04-20_22-54-31", "ostf_sha": "df8db1f48f03b18126ce5ec65317a1eb83a5a95f", "build_number": "329", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-26_14-25-46", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "58", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"}}, "2014.2-6.1": {"VERSION": {"build_id": "2015-04-20_22-54-31", "ostf_sha": "df8db1f48f03b18126ce5ec65317a1eb83a5a95f", "build_number": "329", "api": "1.0", "nailgun_sha": "69fca3bada96a48ab19b969621e5128390b7052e", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "b4f1ddffd5263489090b65e662173e9e11aafd94", "astute_sha": "bf1751a4fe0d912325e3b4af629126a59c1b2b51", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "0c0e299dcc0276bb8262256148c6ee975857ee86", "fuellib_sha": "b878f1ae8e1d4c6f2f463e810b1f8014df5b22a5"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "69fca3bada96a48ab19b969621e5128390b7052e", "openstack_version": "2014.2-6.1", "production": "docker", "python-fuelclient_sha": "b4f1ddffd5263489090b65e662173e9e11aafd94", "astute_sha": "bf1751a4fe0d912325e3b4af629126a59c1b2b51", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "0c0e299dcc0276bb8262256148c6ee975857ee86", "fuellib_sha": "b878f1ae8e1d4c6f2f463e810b1f8014df5b22a5"}

Steps:
1. Install 6.0-58, deploy cluster
2. Create two instances
3. Upgrade to 6.1-329
4. Check oswl_stats: select * from oswl_stats;

Expected: 6.0 cluster appeared in oswl_stats;
Actual: empty

nailgun=> \d oswl_stats;
                                      Table "public.oswl_stats"
      Column | Type | Modifiers
-------------------+------------------------+---------------------------------------------------------
 id | integer | not null default nextval('oswl_stats_id_seq'::regclass)
 cluster_id | integer | not null
 created_date | date | not null
 updated_time | time without time zone | not null
 resource_type | oswl_resource_type | not null
 resource_data | text |
 resource_checksum | text |
 is_sent | boolean | not null
Indexes:
    "oswl_stats_pkey" PRIMARY KEY, btree (id)
    "ix_oswl_stats_cluster_id" btree (cluster_id)
    "ix_oswl_stats_created_date" btree (created_date)
    "ix_oswl_stats_is_sent" btree (is_sent)
    "ix_oswl_stats_resource_type" btree (resource_type)

5. Run 'oswl_collectord vm'
Actual: no errors http://paste.openstack.org/show/205019/

[Artem Roma (aroma-x)]

Cannot reproduce after upgrading to build #353. Move to invalid.

[Mike Scherbakov (mihgen)]

Artem, you moved to Incomplete actually. Did you intend to move it to Invalid?

[Artem Roma (aroma-x)]

Mike, yes, my intentions was moving to invalid. Thank you for your observation.

[Maksym Strukov (unbelll)]

{"build_id": "2015-04-27_22-54-38", "build_number": "357", "release_versions": {"2014.2-6.0": {"VERSION": {"build_id": "2014-12-26_14-25-46", "ostf_sha": "a9afb68710d809570460c29d6c3293219d3624d4", "build_number": "58", "api": "1.0", "nailgun_sha": "5f91157daa6798ff522ca9f6d34e7e135f150a90", "production": "docker", "fuelmain_sha": "81d38d6f2903b5a8b4bee79ca45a54b76c1361b8", "astute_sha": "16b252d93be6aaa73030b8100cf8c5ca6a970a91", "feature_groups": ["mirantis"], "release": "6.0", "fuellib_sha": "fde8ba5e11a1acaf819d402c645c731af450aff0"}}, "2014.2.2-6.1": {"VERSION": {"build_id": "2015-04-27_22-54-38", "build_number": "357", "api": "1.0", "fuel-library_sha": "0e5b82d24853304befb22145ac4aaf3545d295e1", "nailgun_sha": "5e52637d9944c2f4170012560d15ecf89a691af6", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "8cd6cf575d3c101dee1032abb6877dfa8487e077", "astute_sha": "c1793f982fda7e3fc7b937ccaa613c649be6a144", "fuel-ostf_sha": "b38602c841deaa03ddffc95c02f319360462cbe3", "release": "6.1", "fuelmain_sha": "1ec588d364b9b97f124f6d602dbcc4aa13327218"}}}, "auth_required": true, "api": "1.0", "fuel-library_sha": "0e5b82d24853304befb22145ac4aaf3545d295e1", "nailgun_sha": "5e52637d9944c2f4170012560d15ecf89a691af6", "feature_groups": ["mirantis"], "openstack_version": "2014.2.2-6.1", "production": "docker", "python-fuelclient_sha": "8cd6cf575d3c101dee1032abb6877dfa8487e077", "astute_sha": "c1793f982fda7e3fc7b937ccaa613c649be6a144", "fuel-ostf_sha": "b38602c841deaa03ddffc95c02f319360462cbe3", "release": "6.1", "fuelmain_sha": "1ec588d364b9b97f124f6d602dbcc4aa13327218"}

Verified as no repro in 6.1-357

[Dmitry Pyzhov (dpyzhov)]

As I understand the issue appears if user change admin password _after_ upgrade.

[Maksym Strukov (unbelll)]

No, I didn't change admin password

[Andrey Sledzinskiy (asledzinskiy)]

Issue isn't reproduced
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "412"
  build_id: "2015-05-13_11-36-33"
  nailgun_sha: "09a9f2726223b9f31075adf79898045cd269c00c"
  python-fuelclient_sha: "af6c9c3799b9ec107bcdc6dbf035cafc034526ce"
  astute_sha: "484d5038b81b7260597be027b1265dc88091026b"
  fuel-library_sha: "86505a5b4aab91b16abacca9a0da4f4cf90d3da9"
  fuel-ostf_sha: "1ae384a28b42d5325bd5d2546aead1e9d502f6a8"
  fuelmain_sha: "51b86bb24b27742a22b23e2ae3dfc850c47e5fbf"