OS::Heat:Autoscaling group Fn::GetAttr does not work for attributes 'outputs' and 'outputs_list'

Bug #1444286 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Rabi Mishra

Bug Description

OS::Heat:Autoscaling group Fn::GetAttr does not work for attributes 'outputs' and 'outputs_list' while using template version 2013-05-23.

It returns an error during stack-show for the specific output:

For something like

outputs:
server_names:
value: {get_attr: [asg, outputs_list, name]}

"The Referenced Attribute (asg outputs_list) is incorrect"

It seems get_attr is mapped to hot_funcs.GetAttThenSelect for 2013-05-23.

https://github.com/openstack/heat/blob/master/heat/engine/hot/template.py#L64.

Either we should support this for older templates or mention that these attributes are only supported >=2014-10-16.

Rabi Mishra (rabi)
Changed in heat:
assignee: nobody → Rabi Mishra (rabi)
Revision history for this message
Steven Hardy (shardy) wrote :

This is expected, because path based attributes require 2014-10-16, but it sounds like we need to improve the docs to make that clear.

We should not change the behaviour of the old HOT version, IMO the correct fix is to update the docs.

As a start these should probably mention it:

http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#get-attr

http://docs.openstack.org/hot-guide/content/get-access-to-nested-attributes.html

Changed in heat:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/173712

Changed in heat:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/173727

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/173727
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3333c42d85d2a13dc1ed87b7e593cd001f11d117
Submitter: Jenkins
Branch: master

commit 3333c42d85d2a13dc1ed87b7e593cd001f11d117
Author: Rabi Mishra <email address hidden>
Date: Wed Apr 15 14:25:38 2015 +0530

    Update documentation for path based nested attribute access

    Change-Id: I799333a08adeb15dad5397aa67bb014a574acad1
    Partial-Bug: #1444286

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/173712
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d8e45933bcd14339b8fe07507d8b3362ba520375
Submitter: Jenkins
Branch: master

commit d8e45933bcd14339b8fe07507d8b3362ba520375
Author: Rabi Mishra <email address hidden>
Date: Wed Apr 15 12:59:05 2015 +0530

    Clarify `attributes` support status for AutoScalingGroup

    Clarify that latest HOT is required for path based get_attr
    calls using 'outputs' and 'outputs_list'.

    Change-Id: I44de426a61726d27616f6dd8a38e676fb2a6fbcc
    Closes-Bug: #1444286

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.