Fuel dos.py failing to properly configure slave network interfaces

Bug #1444058 reported by Alex Schultz
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Dmitry Tyzhnenko

Bug Description

When attempting to create a new environment manually via dos.py, slave nodes are not properly getting network interfaces attached to them.

Steps to reproduce:

1) dos.py create --vcpu 1 --node-count 2 --ram 2048 --iso-path ~/arch/fuel-6.1-282-2015-04-06_08-49-30.iso as
2) view the as_slave-1 node's configuration and note the lack of network interfaces on the VM

Possible cause:
In attempting to debug why this is happening, I discovered the node.attach_to_networks function wasn't actually getting any networks back from the self.environment.get_networks(...) call. Specifically this issue can be resolved in devops/models/node.py[0]. This call is getting passed to a django queryset filter(...) call in an attempt to get the networks to be used to attach to the node. Because the network list being passed is an array, the get_networks(name=[...]) call should be get_networks(name__in=[...]) so that it will properly do an IN query[1].

[0] https://github.com/stackforge/fuel-devops/blob/master/devops/models/node.py#L191
[1] https://docs.djangoproject.com/en/dev/ref/models/querysets/#in

Changed in fuel:
milestone: none → 7.0
assignee: nobody → MOS QA Team (mos-qa)
Changed in fuel:
importance: Undecided → Medium
tags: added: qa-agree-7.0
Changed in fuel:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-devops (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182392

Changed in fuel:
assignee: MOS QA Team (mos-qa) → Alex Schultz (alex-schultz)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-devops (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/182392
Reason: Abandoning for https://review.openstack.org/#/c/184102/ instead.

Changed in fuel:
assignee: Alex Schultz (alex-schultz) → Dmitry Tyzhnenko (dtyzhnenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-devops (master)

Reviewed: https://review.openstack.org/184102
Committed: https://git.openstack.org/cgit/stackforge/fuel-devops/commit/?id=48974665637fc97502b4347efa7a7580096a0b7a
Submitter: Jenkins
Branch: master

commit 48974665637fc97502b4347efa7a7580096a0b7a
Author: Dmitry Tyzhnenko <email address hidden>
Date: Mon May 18 20:41:14 2015 +0300

    Change logic of get networks in attach_to_networks

    In attach_to_networks method replace get_networks method to
       get_network and loop. This behavior save order of nets
       which setted via system environment.

    Change-Id: I2186acbae44aa64dab311bd1224e1c7540547a63
    Closes-bug: #1456288
    Closes-bug: #1444058
    Closes-bug: #1454786

Changed in fuel:
status: In Progress → Fix Committed
tags: added: non-release
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.