tor agent crash on adding multicast route

[Manish Singh]

When link from VN to VRF is not present addition of multicast route will crash.

BT:

#0 0x00007ffff5bda5c8 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x000000000114ca7e in MulticastRoute::MulticastRoute (this=0x7fffac366bf0,
    vn_name=<error reading variable: Cannot access memory at address 0xb0>, label=0, vxlan_id=1199, tunnel_type=8, nh_req=...,
    comp_nh_type=Composite::L2COMP) at controller/src/vnsw/agent/oper/agent_path.h:508
#2 0x0000000001148d36 in BridgeAgentRouteTable::AddOvsPeerMulticastRoute (this=0x7fffbc088950, peer=0x7fffe805cac0, vxlan_id=1199,
    tsn=..., tor_ip=...) at controller/src/vnsw/agent/oper/bridge_route.cc:147

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9065
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9453
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9065
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9065
Committed: http://github.org/Juniper/contrail-controller/commit/a904a762c801ce4a6dd483c33b96d60ec5891606
Submitter: Zuul
Branch: master

commit a904a762c801ce4a6dd483c33b96d60ec5891606
Author: Manish <email address hidden>
Date: Tue Apr 28 16:55:31 2015 +0530

Tor agent crashes during addition of multicast route.

Problem:
When VN to VRF link is not present addition of multicast route in tor agent
used to crash as addition routine tries to access VN name from VRF entry.
Absence of link used to return NULL VN and accessing it for VN name
results in crash.

Solution:
Use VN name from VN OVSDB entry. Pass it along in API.
Multicast OVSDB does not gets resolved till VN OVSDB is resolved,
hence using VN name from same is safe.

Conflicts:
 src/vnsw/agent/oper/vn.cc
 src/vnsw/agent/oper/vn.h
 src/vnsw/agent/test/test_util.cc

Change-Id: If9cf04ba8a424957dcdb9559d0b99b67d868d32f
Closes-bug: 1443318

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10336
Submitter: Manish Singh (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/10336
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/10336
Committed: http://github.org/Juniper/contrail-controller/commit/ce36b77733fff8b4837b031ff73a9866299aaf18
Submitter: Zuul
Branch: R2.20

commit ce36b77733fff8b4837b031ff73a9866299aaf18
Author: Manish <email address hidden>
Date: Tue Apr 28 16:55:31 2015 +0530

Tor agent crashes during addition of multicast route.

Problem:
When VN to VRF link is not present addition of multicast route in tor agent
used to crash as addition routine tries to access VN name from VRF entry.
Absence of link used to return NULL VN and accessing it for VN name
results in crash.

Solution:
Use VN name from VN OVSDB entry. Pass it along in API.
Multicast OVSDB does not gets resolved till VN OVSDB is resolved,
hence using VN name from same is safe.

Conflicts:
 src/vnsw/agent/oper/vn.cc
 src/vnsw/agent/oper/vn.h
 src/vnsw/agent/test/test_util.cc

Closes-bug: 1443318
(cherry picked from commit a904a762c801ce4a6dd483c33b96d60ec5891606)

Change-Id: Ic4d4949ee69bf811bca426e7d324c6b64d4330a9