Clean authorization mocking in fuelclient tests

Bug #1443279 reported by Sebastian Kalinowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Sebastian Kalinowski

Bug Description

After https://github.com/stackforge/python-fuelclient/commit/9b0b6ab2f09ff75445550b7210104e21df5d8cd6 , due to 'requests' mocking, "Client" singleton and caching in it, results in sharing authorization state between tests which sometimes leads to strange results and errors in tests (especially when running just a subset of tests with ./run_tests.sh).

Mocking of authorization should be done like in 'execute_wo_auth' method in tests.

Changed in fuel:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/172822

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/172822
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=ff186de358cbda489a320723de47a9e61ae23364
Submitter: Jenkins
Branch: master

commit ff186de358cbda489a320723de47a9e61ae23364
Author: Sebastian Kalinowski <email address hidden>
Date: Mon Apr 13 09:30:10 2015 +0200

    Clean authorization mocking in tests

    Remove remaining 'execute_wo_tests' as now authorization is
    mocked in all tests by default.
    Changed mocking from 'auth_client' to 'auth_required' to make
    it simple to change in tests (now it's just a matter of changing
    boolean).

    Change-Id: Icfd0ef3058918e1578a21429f84a1583eddd3a8e
    Closes-Bug: #1443279

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.