make timeouts configure from task or conf file and not hard-coded

Bug #1443035 reported by Asaf Hirshberg
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Wishlist
Chris St. Pierre

Bug Description

while running some tests i had to modify the code in order to play with time-outs of wait_for_ping:

    def _wait_for_ping(self, server_ip):
              bench_utils.wait_for(
                 server_ip,
                 is_ready=self._ping_ip_address,
                 timeout=300

parameters like that should be modify in the JSON/YAML or some centralized location instead of modifying code or a default value in the code and an option to change it in the JSON/YAML.

Revision history for this message
Boris Pavlovic (boris-42) wrote :

I believe it should be at least in rally.conf

Changed in rally:
status: New → Triaged
summary: - move changing of code-timeout to centralized location instead of
- modifying code
+ make timeouts configure from task or conf file and not hard-coded
Changed in rally:
importance: Undecided → Wishlist
Yair Fried (yfried)
Changed in rally:
importance: Wishlist → Undecided
importance: Undecided → Wishlist
Changed in rally:
assignee: nobody → Yair Fried (yfried)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on rally (master)

Change abandoned by Yair Fried (<email address hidden>) on branch: master
Review: https://review.openstack.org/204577
Reason: https://review.openstack.org/#/c/192776/

Changed in rally:
status: Triaged → In Progress
Changed in rally:
assignee: Yair Fried (yfried) → Chris St. Pierre (stpierre)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/192776
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=b5b33943ccff7acc1e3818b88c191bf5712a2299
Submitter: Jenkins
Branch: master

commit b5b33943ccff7acc1e3818b88c191bf5712a2299
Author: Chris St. Pierre <email address hidden>
Date: Wed Jun 17 12:01:24 2015 -0500

    VMTasks: Make waiting for ping timing configurable

    Poll interval and timeout can now be set in rally.conf

    Closes-Bug: #1443035
    Change-Id: Ia6d297f2fb8202ac7c00917b05a8db3480dcc5b6

Changed in rally:
status: In Progress → Fix Committed
Changed in rally:
milestone: none → 0.1.0
Changed in rally:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.