Functional test has invalid checks on returned meta

Bug #1443007 reported by Dave McCowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
Dave McCowan

Bug Description

The following new functional test cases fail.

Functional Test Cases:
ERROR: functionaltests.api.v1.smoke.test_rsa.RSATestCase.test_rsa_order_certificate_from_csr
ERROR: functionaltests.api.v1.smoke.test_rsa.RSATestCase.test_rsa_order_certificate_from_generated_container
ERROR: functionaltests.api.v1.smoke.test_rsa.RSATestCase.test_rsa_order_certificate_from_generated_container_with_pass

Result:

Response: {"status": "PENDING", "sub_status": "cert_request_pending", "updated": "2015-04-12T04:18:35.735101", "created": "2015-04-12T04:18:35.661890", "order_ref": "http://localhost:9311/v1/orders/cc5e8dd4-9a82-4c56-9ff6-52ccc9babbbd", "creator_id": "3f508ea90734425c97355294cb87cdb1", "meta": {"subject_dn": "cn=server.example.com,o=example.com", "container_ref": "http://localhost:9311/v1/containers/2ceaed65-3c19-4bac-ab64-adc3283aa50a", "requestor_name": "Barbican User", "requestor_email": "<email address hidden>", "request_type": "stored-key", "requestor_phone": "555-1212"}, "sub_status_message": "Request has been submitted to the CA. Waiting for certificate to be generated", "type": "certificate"}

Expected:

I expect "plugin_name": "<some name>" and
"generated_csr": "<the csr>" to be part of the meta:{} in the
response to get order, but they are not.

Changed in barbican:
milestone: none → kilo-rc1
Revision history for this message
Dave McCowan (dave-mccowan) wrote :

Turns out this behavior is as designed.
The bug is in the test case.
This bug will be used to fix the test case.

Changed in barbican:
status: New → In Progress
assignee: nobody → Dave McCowan (dave-mccowan)
summary: - Response to Get Certificate Order Requests Do Not Have Updated Meta
+ Functional test has invalid checks on returned meta
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/173163

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/173163
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=ce948505eca6790abb2f7d1731074421a5938d8f
Submitter: Jenkins
Branch: master

commit ce948505eca6790abb2f7d1731074421a5938d8f
Author: Dave McCowan <email address hidden>
Date: Mon Apr 13 20:38:26 2015 -0700

    Fix expectations of order certificate test cases

    Remove the checks that looked for generated_csr and plugin_name
    meta values in a get order response. These are field are for
    use only internally to Barbican and are not return on a get
    order request.

    Change-Id: I5797eab13a1e33e95910d810f9e9b250e0fa3767
    Closes-bug: #1443007

Changed in barbican:
status: In Progress → Fix Committed
Changed in barbican:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.