Quobyte unit test fails sometimes: manila.tests.share.drivers.quobyte.test_jsonrpc.QuobyteJsonRpcTestCase.test_jsonrpc_call_ssl_error

[Ben Swartzlander]

======================================================================
FAIL: manila.tests.share.drivers.quobyte.test_jsonrpc.QuobyteJsonRpcTestCase.test_jsonrpc_call_ssl_error
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "/home/bswartz/src/manila/manila/tests/share/drivers/quobyte/test_jsonrpc.py", line 201, in test_jsonrpc_call_ssl_error
    six.text_type(me))
  File "/home/bswartz/src/manila/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/bswartz/src/manila/.venv/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = 'Client SSL subsystem returned error: '
actual = u'Client SSL subsystem returned error: ()'

It seems like this test is relying a specific string from the SSL library, and on my system the SSL library is returning a slightly different string. The test could be made less fragile by changing the assertMatch to assertTrue(me.startswith('Client SSL subsystem returned error:'))

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/172809

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/172809
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=f5b03ae0232f26d0dd203666d0b6589e7075bb81
Submitter: Jenkins
Branch: master

commit f5b03ae0232f26d0dd203666d0b6589e7075bb81
Author: Silvan Kaiser <email address hidden>
Date: Mon Apr 13 08:51:20 2015 +0200

    More flexible matching in SSL error test

    Change assert match string to be more flexible in
    QuobyteJsonRpcTestCase.test_jsonrpc_call_ssl_error .
    Instead of matching the whole string match based on
    startswith in order not to fail on different SSL libraries.

    Change-Id: I4021a742d0e9b7e59e0da73ac22c1a37fda542ba
    Closes-Bug: 1442768