[System Tests] Collector settings weren't set during system test

[Andrey Sledzinskiy]

Error Message

Command dockerctl shell nailgun grep -sw "ERROR" /var/log/nailgun/statsenderd.log returned exit code "0", but expected "1". Output: ['2015-04-10 07:21:00.044 ERROR [7fa02fe85700] (statsenderd) Collector ping failed: ConnectionError\n']; []

Stacktrace
Somehow collector settings were deleted from settings.yaml during the test

Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_3/fuelweb_test/helpers/decorators.py", line 66, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_3/fuelweb_test/tests/test_ceph.py", line 310, in check_openstack_stat
    self.env.nailgun_actions.force_fuel_stats_sending()
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_3/fuelweb_test/helpers/fuel_actions.py", line 184, in force_fuel_stats_sending
    self.execute_in_container(cmd, exit_code=1)
  File "/home/jenkins/workspace/6.1.system_test.ubuntu.thread_3/fuelweb_test/helpers/fuel_actions.py", line 50, in execute_in_container
    err=result['stderr']
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/asserts.py", line 55, in assert_equal
    raise ASSERTION_ERROR(message)
AssertionError: Command dockerctl shell nailgun grep -sw "ERROR" /var/log/nailgun/statsenderd.log returned exit code "0", but expected "1". Output: ['2015-04-10 07:21:00.044 ERROR [7fa02fe85700] (statsenderd) Collector ping failed: ConnectionError\n']; []

[Andrey Sledzinskiy (asledzinskiy)]

So the reason of issue was found - during snapshot reverting we destroy admin node in case it wasn't reverted
2015-04-21 07:09:45,331 - WARNING environment.py:221 -- From first time admin isn't reverted: [Errno 113] No route to host
2015-04-21 07:09:45,940 - INFO environment.py:223 -- Admin node was destroyed. Wait 10 sec.
2015-04-21 07:09:56,949 - INFO environment.py:226 -- Admin node started second time.

This destroy restart nailgun container and we lose all our settings.
As workaround we can add collector settings outside the container in /etc/fuel/version.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/175938

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/175938
Committed: https://git.openstack.org/cgit/stackforge/fuel-qa/commit/?id=f318245685e9a3e4c7a3b2e9f1a0e01d5f441bdb
Submitter: Jenkins
Branch: master

commit f318245685e9a3e4c7a3b2e9f1a0e01d5f441bdb
Author: asledzinskiy <email address hidden>
Date: Wed Apr 22 15:54:04 2015 +0300

    Set collector settings again in case revert fails

    - Collector settings are added in revert snapshot method
    in order to avoid situation when after revert master node is
    not started and her destroying erases all settings in container

    Change-Id: Ic3817c7eb6c6d379086771fbf49ed6dbc6c4ca3d
    Closes-Bug: #1442600