audio-recorder fails to build on top of GNOME 3.16

[DimStar]

With the base libraries all updated to the GNOME 3.16 release, audio recorder (up to version 1.6) fails to build.

[ 114s] In file included from /usr/include/gtk-3.0/gtk/gtk.h:279:0,
[ 114s] from gtklevelbar.h:6,
[ 114s] from gtklevelbar.c:19:
[ 114s] /usr/include/gtk-3.0/gtk/gtk-autocleanups.h:117:1: error: unknown type name 'GtkLevelBar'
[ 114s] G_DEFINE_AUTOPTR_CLEANUP_FUNC(GtkLevelBar, g_object_unref)
[ 114s] ^
[ 114s] In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
[ 114s] from /usr/include/glib-2.0/glib/gtypes.h:32,
[ 114s] from /usr/include/glib-2.0/glib/galloca.h:32,
[ 114s] from /usr/include/glib-2.0/glib.h:30,
[ 114s] from /usr/include/gtk-3.0/gdk/gdkconfig.h:13,
[ 114s] from /usr/include/gtk-3.0/gdk/gdk.h:30,
[ 114s] from /usr/include/gtk-3.0/gtk/gtk.h:30,
[ 114s] from gtklevelbar.h:6,
[ 114s] from gtklevelbar.c:19:
[ 114s] /usr/include/gtk-3.0/gtk/gtk-autocleanups.h:117:31: error: unknown type name 'GtkLevelBar'

[moma (osmoma)]

Hello,
Audio-recorder and GTK3+ seems to have the same widget class GtkLevelBar. Both does the same thing. I created a GtkLevelBar widget for 4 years ago and added it to the audio-recorder. Now GTK3 provides the same functionality.

Please see: https://developer.gnome.org/gtk3/stable/GtkLevelBar.html
And
http://bazaar.launchpad.net/~audio-recorder/audio-recorder/trunk/view/head:/src/gtklevelbar.c
(gtklevelbar.c and gtklevelbar.h).

You should remove the gtklevelbar.[ch] files from the project and use the standard GtkLevelBar from GTK3+.
You should also remove code for left-click and right-click events on that widget.
Ref: http://bazaar.launchpad.net/~audio-recorder/audio-recorder/trunk/view/head:/src/main.c#L995

Look for and change all references to "gtk_level". Run this command to find files from the base "audio-recorder" folder.

$ grep -Ri gtklevelbar

Modify also
src/Makefile.am and po/POTFILES.in

Then run:
make clean
aclocal
autoconf
automake -a
./configure
make

Alternative solution is to rename GtkLevelBar in gtklevelbar.c and gtklevelbar.h and then change all references to it.

BTW: The development of audio-recorder has been taken over by Team "Audio-Recorder".
Please join to the team if you have time. Team members can create their own branches and push changes to the Launchpad.
Ref: https://lists.launchpad.net/audio-recorder/msg00007.html

Good luck.

[moma (osmoma)]

Re-hi,

I decided to rename our GtkLevelBar widget to "LevelBar". I also renamed src/gtklevelbar.[ch] to src/levelbar.[ch].
I have commited the changes to my private branch.

It would be OKAY to use the standard GtkLevelBar in audio-recorder, but our own version has some extra features. It can show the level text (values) and it can change its shape. Just left / right click the levelbar widget to see this. So I decided to keep it in our project.

I have not yet merged these changes to the main trunk. Please take a copy of my private branch.
https://code.launchpad.net/~osmoma/audio-recorder/trunk

with:
bzr branch lp:~osmoma/audio-recorder/trunk

Please re-compile this version on your system and report if sucess or failure.
You are welcome to create your own code branch and join to the Team.

Obrigado
  moma antero (osmoma)

[moma (osmoma)]

I pushed the changes to the main trunk.
https://code.launchpad.net/~audio-recorder/audio-recorder/trunk