Ajax block-loading doesn't work in "Copy a page" screen's page preview

Bug #1442130 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

The "Copy a page" screen lets you see a preview of a page, in a little popup. Ajax page-loading doesn't work on preview.

To replicate:

1. Create a page. Put a text block in it.
2. Go to Portfolio -> Pages
3. Click the "Copy a page" button in the upper-right
4. Click the title of the page you created

Expected result: You should see the page preview, with the text block
Actual result: You see the page preview, with a spinner in place of the text block

Revision history for this message
Robert Lyon (robertl-9) wrote :

This patch

https://reviews.mahara.org/#/c/4303/

 is meant to deal with the export and page preview of pages to not use the ajax method.

Son was saying that we should split up the patch so that there is one for the preview of page part - and the other for the export of pages part.

So I'll try and get that patch split up

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4592

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4592
Committed: http://gitorious.org/mahara/mahara/commit/e7665b43ae82e2e9c6e09edd6547398e44ee9b68
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e7665b43ae82e2e9c6e09edd6547398e44ee9b68
Author: Robert Lyon <email address hidden>
Date: Mon Apr 13 14:35:31 2015 +1200

Allow the page preview to show actual content (Bug #1442130)

Rather than the loading spinners

Change-Id: I051fedd6bb8ee5061960c5f6bb2a67fb5b72d9ad
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4633

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4633
Committed: http://gitorious.org/mahara/mahara/commit/dc5632c8a898f202e670954e28ba05be87570567
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit dc5632c8a898f202e670954e28ba05be87570567
Author: Robert Lyon <email address hidden>
Date: Mon Apr 13 14:35:31 2015 +1200

Allow the page preview to show actual content (Bug #1442130)

Rather than the loading spinners

Change-Id: I051fedd6bb8ee5061960c5f6bb2a67fb5b72d9ad
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.