Brocade Vyatta Firewall feature impacted by L3 agent refactor

Bug #1442043 reported by vishwanath jayaraman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
vishwanath jayaraman
Kilo
Fix Released
High
Unassigned

Bug Description

The patch set https://review.openstack.org/#/c/163222/ related to L3 restructure that got merged removed the "process_router()" method that the VyattaFirewallAgent class was using. The impact is that firewall is not updated or applied on the Vyatta VRouter as expected when an end user executes "Set Gateway" or "add/remove interfaces" method on the router.

Changed in neutron:
assignee: nobody → vishwanath jayaraman (vishwanathj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171998

Changed in neutron:
status: New → In Progress
Kyle Mestery (mestery)
Changed in neutron:
milestone: none → liberty-1
importance: Undecided → High
Kyle Mestery (mestery)
tags: added: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/171998
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=650e68b4f7a43b9a54f7bffac4d6055d6951163e
Submitter: Jenkins
Branch: master

commit 650e68b4f7a43b9a54f7bffac4d6055d6951163e
Author: Vishwanath Jayaraman <email address hidden>
Date: Thu Apr 9 05:15:37 2015 -0500

    Restore Brocade Vyatta firewall functionality

    Code changes related to the patch set
    I467bb680666ec9bc82e55cfe534d74db29009cce removed the process_router()
    method that was being used by the Vyatta Firewall agent code to
    update/apply firewall to the Vyatta VRouter when an end user executed
    the "Set Gateway" or "Add/Remove interfaces" method on a router.

    The current patch set restores the functionality by leveraging
    functionality provided by neutron.callbacks.

    Change-Id: If3ad35ff08d69b6567350354bc7f4bf7fc71f263
    Closes-Bug: #1442043

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (proposed/kilo)

Fix proposed to branch: proposed/kilo
Review: https://review.openstack.org/173902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/174058

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron-fwaas (proposed/kilo)

Change abandoned by Doug Hellmann (<email address hidden>) on branch: proposed/kilo
Review: https://review.openstack.org/173902
Reason: replaced by https://review.openstack.org/174058 on stable/kilo

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (stable/kilo)

Reviewed: https://review.openstack.org/174058
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=f4eca886ed66d46ea29648dbe7179f6ae97db262
Submitter: Jenkins
Branch: stable/kilo

commit f4eca886ed66d46ea29648dbe7179f6ae97db262
Author: Vishwanath Jayaraman <email address hidden>
Date: Thu Apr 9 05:15:37 2015 -0500

    Restore Brocade Vyatta firewall functionality

    Code changes related to the patch set
    I467bb680666ec9bc82e55cfe534d74db29009cce removed the process_router()
    method that was being used by the Vyatta Firewall agent code to
    update/apply firewall to the Vyatta VRouter when an end user executed
    the "Set Gateway" or "Add/Remove interfaces" method on a router.

    The current patch set restores the functionality by leveraging
    functionality provided by neutron.callbacks.

    Change-Id: If3ad35ff08d69b6567350354bc7f4bf7fc71f263
    Closes-Bug: #1442043
    (cherry picked from commit 650e68b4f7a43b9a54f7bffac4d6055d6951163e)

Thierry Carrez (ttx)
tags: removed: kilo-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179303

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/179303
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=a32bbe40b703a5f366d4412d9dabecf807ef416d
Submitter: Jenkins
Branch: master

commit c68aa0cbe243825bff5194d5af14899723cd3f71
Author: Thierry Carrez <email address hidden>
Date: Fri Apr 17 10:29:56 2015 +0200

    update .gitreview for stable/kilo

    Change-Id: I2a7a9f13b520887b9f7f6dc8ee312c6eee1313ea

commit f2da3940a4574764b9defa316be75b0f0613a360
Author: Romil Gupta <email address hidden>
Date: Sun Mar 29 07:55:58 2015 -0700

    Updated Protocol named constants

    The L3 protocol name constants should be removed from
    neutron/plugins/common/constants.py because for instance, there
    exists a constant already in neutron/common/constants.py for
    tcp - PROTO_NAME_TCP.

    Moved out FWaaS specific constants from
    neutron.plugins.common.constants to here.

    Reference:
    https://review.openstack.org/#/c/166879/

    (cherry picked from commit d6559ddcd0befc9434f4d27ee0bb7e31cf98c60e)
    Change-Id: Ic9dc026f4165c3ea00d472bfb7bd8edaf89ce7c0

commit 3bc3270c46192a8f73c484759e4db9f41ba9300f
Author: Henry Gessau <email address hidden>
Date: Thu Apr 16 14:00:27 2015 -0400

    Add Kilo release milestone

    Change-Id: I8e24ea3efa13b3858423e785f5f2373246cd8e04

commit 0f81b6e19147a81b37e97958a0939aac8b335a97
Author: Kyle Mestery <email address hidden>
Date: Wed Apr 15 19:58:29 2015 +0000

    Pin neutron to stable/kilo

    Since the *aaS repositories require a dependency on neutron, we want
    to pin the stable branches to the matching neutron branch.

    Change-Id: I8fd4227dbae1ac0f19bcfbdab9b39ab4dba04c6e

commit f4eca886ed66d46ea29648dbe7179f6ae97db262
Author: Vishwanath Jayaraman <email address hidden>
Date: Thu Apr 9 05:15:37 2015 -0500

    Restore Brocade Vyatta firewall functionality

    Code changes related to the patch set
    I467bb680666ec9bc82e55cfe534d74db29009cce removed the process_router()
    method that was being used by the Vyatta Firewall agent code to
    update/apply firewall to the Vyatta VRouter when an end user executed
    the "Set Gateway" or "Add/Remove interfaces" method on a router.

    The current patch set restores the functionality by leveraging
    functionality provided by neutron.callbacks.

    Change-Id: If3ad35ff08d69b6567350354bc7f4bf7fc71f263
    Closes-Bug: #1442043
    (cherry picked from commit 650e68b4f7a43b9a54f7bffac4d6055d6951163e)

Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.